Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing NonNullable Reference Types preview fails #29987

Closed
Suchiman opened this issue Sep 18, 2018 · 17 comments
Closed

Installing NonNullable Reference Types preview fails #29987

Suchiman opened this issue Sep 18, 2018 · 17 comments
Labels
Area-Compilers Bug New Language Feature - Nullable Reference Types Nullable Reference Types
Milestone
16.0.P1

Comments

@Suchiman
Copy link
Contributor

Suchiman commented Sep 18, 2018 •
edited
Loading

Version Used:
15.8.4 / 15.9 preview 2
(english VS on german windows 10 Pro 1803)

Steps to Reproduce:

  1. Download preview and unzip
  2. Run .\install.bat from elevated prompt
Installing Roslyn Insiders Build
Installing Preview Into C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\devenv.exe
Using VS Instance 75b52a36 at "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise"
"C:\Users\Robin\Downloads\NonNull\tools\vsixexpinstaller\VsixExpInstaller.exe" /rootSuffix: /u /vsInstallDir:"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise" "C:\Users\Robin\Downloads\NonNull\vsix\RoslynDeployment.vsix"
  Running as Admin.
  de-DE
  Nothing to uninstall...
Using VS Instance 75b52a36 at "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise"
"C:\Users\Robin\Downloads\NonNull\tools\vsixexpinstaller\VsixExpInstaller.exe" /rootSuffix: /vsInstallDir:"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise" "C:\Users\Robin\Downloads\NonNull\vsix\RoslynDeployment.vsix"
  Running as Admin.
  de-DE
  Installing local extension: 'C:\Users\Robin\Downloads\NonNull\vsix\RoslynDeployment.vsix'

Unhandled Exception: System.Runtime.InteropServices.COMException: Element not found. (Exception from HRESULT: 0x80070490)
   at Microsoft.VisualStudio.Setup.Configuration.ISetupConfiguration2.GetInstanceForCurrentProcess()
   at Microsoft.VisualStudio.ExtensionManager.ExtensionManagerService.get_VsProductVersion()
   at Microsoft.VisualStudio.ExtensionManager.Utilities.GetRunningSKUVersionAndEdition(String& version, String& edition)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionManagerService.get_VersionAndEdition()
   at Microsoft.VisualStudio.ExtensionManager.InstalledExtensionImpl.get_VsVersion()
   at Microsoft.VisualStudio.ExtensionManager.InstalledExtensionImpl.AssetTargetsVsVersion(IDictionary`2 attributes)
   at Microsoft.VisualStudio.ExtensionManager.InstalledExtensionImpl.RemoveInapplicableAssets()
   at Microsoft.VisualStudio.ExtensionManager.InstalledExtensionImpl..ctor(IExtension extension, String installPath, IEngineHost engineHost, Boolean installedPerMachine)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.ToInstalledExtension(InstallableExtensionImpl extension, Boolean perMachine)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.<>c__DisplayClass183_0.<PreviewInstalledExtensions>b__4(InstallableExtensionImpl installableExtension)
   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.PreviewInstalledExtensions(InstallableExtensionImpl extension, Boolean perMachine, List`1 previewedInstalledExtensions, IInstalledExtensionList modifiedInstalledExtensionsList)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.FindRecursiveInstallConflicts(InstallableExtensionImpl extension, IInstalledExtensionList modifiedInstalledExtensionsList, List`1 impactedExtensions, Boolean isNested)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.ExtensionRequiresAdditionalOperationForInstall(InstallableExtensionImpl extension, IInstalledExtensionList modifiedInstalledExtensionsList, Boolean isNestedExtension, InstallFlags flags, Boolean& performExtensionUpdate)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.InstallInternal(InstallableExtensionImpl extension, InstallFlags installFlags, IDictionary`2 extensionsInstalledSoFar, List`1 extensionsUninstalledSoFar, IInstalledExtensionList modifiedInstalledExtensionsList, AsyncOperation asyncOp, IProgress`1 progress, Version targetedVsVersion)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.BeginInstall(IInstallableExtension installableExtension, InstallFlags installFlags, AsyncOperation asyncOp, Version targetedVsVersion)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.Install(IInstallableExtension extension, InstallFlags installFlags, Version targetedVsVersion)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionManagerService.Install(IInstallableExtension extension, Boolean perMachine)
   at VsixExpInstaller.Program.<>c__DisplayClass16_0.<Main>g__Install|7(IInstallableExtension installableExtension, <>c__DisplayClass16_4& , <>c__DisplayClass16_5& )
   at VsixExpInstaller.Program.<>c__DisplayClass16_0.<Main>g__RunProgram|1()
   at VsixExpInstaller.Program.Main(String[] args)
Command failed to execute: "C:\Users\Robin\Downloads\NonNull\tools\vsixexpinstaller\VsixExpInstaller.exe" /rootSuffix: /vsInstallDir:"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise" "C:\Users\Robin\Downloads\NonNull\vsix\RoslynDeployment.vsix"
System.Management.Automation.RuntimeException: Command failed to execute: "C:\Users\Robin\Downloads\NonNull\tools\vsixexpinstaller\VsixExpInstaller.exe" /rootSuffix: /vsInstallDir:"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise" "C:\Users\Robin\Downloads\NonNull\vsix\RoslynDeployment.vsix"
at Exec-CommandCore, C:\Users\Robin\Downloads\NonNull\tools\utils.ps1: Line 39
at Exec-Console, C:\Users\Robin\Downloads\NonNull\tools\utils.ps1: Line 71
at Use-VsixTool, C:\Users\Robin\Downloads\NonNull\tools\utils.ps1: Line 149
at Install-VsixViaTool, C:\Users\Robin\Downloads\NonNull\tools\utils.ps1: Line 112
at <ScriptBlock>, C:\Users\Robin\Downloads\NonNull\tools\install.ps1: Line 50

Expected Behavior:
Installs successfully

Actual Behavior:
Fails with exception
@jcouv
Copy link
Member

jcouv commented Sep 18, 2018

Tagging @jmarolf

@jcouv jcouv added this to the 16.0 milestone Sep 18, 2018
@jaredpar jaredpar added the Bug label Sep 18, 2018
@jmarolf
Copy link
Contributor

jmarolf commented Sep 18, 2018

tagging @sharwell who encountered this issue. It appears that this is a breaking change made in 15.8.4

@jcouv
Copy link
Member

jcouv commented Sep 18, 2018

Ouch. We just released our latest nullable preview and users are hitting this.

@jinujoseph Please prioritize this issue.
Let me know if there is anything I can do to help. Thanks

@jinujoseph jinujoseph modified the milestones: 16.0, 16.0.P1 Sep 18, 2018
@cston cston mentioned this issue Sep 18, 2018
Closed
@jinujoseph
Copy link
Contributor

tracking bug on platform team

@f2calv
Copy link

f2calv commented Sep 21, 2018

FYI - continues to fail in 15.8.5

@jcouv
Copy link
Member

jcouv commented Sep 25, 2018

FYI, the fix missed the window for 15.8.5, but is scheduled as part of 15.8.6. Sorry for the wait.

@jcouv
Copy link
Member

jcouv commented Oct 2, 2018

15.8.6 was just released. I may not be able to confirm the fix this afternoon. If anyone here does try, please share your result. Thanks!

@Suchiman
Copy link
Contributor Author

Suchiman commented Oct 2, 2018

@jcouv yay! it works!

@Suchiman Suchiman closed this as completed Oct 2, 2018
@jcouv
Copy link
Member

jcouv commented Oct 2, 2018

Awesome. Thanks @Suchiman for confirming.

@Craigfis
Copy link

Craigfis commented Oct 8, 2018

It won't install on 15.9.0 preview 3 for me.

@jcouv
Copy link
Member

jcouv commented Oct 8, 2018

@Craigfis The nullable preview installer only installs on an RTM version of VS. 15.8.6 is recommended at the moment (latest RTM bits).

@pellea
Copy link

pellea commented Oct 22, 2018

@jcouv Is it possible - at our own risk - to install it on the latest preview bits?

@jcouv
Copy link
Member

jcouv commented Oct 22, 2018 via email

@pellea
Copy link

pellea commented Oct 23, 2018

@jcouv I have the 15.9 preview 3 like @Craigfis. I don't really want to downgrade VS (I don't even know if that is possible).

@chucker
Copy link

chucker commented Oct 23, 2018

@pellea VS Preview installs side-by-side with VS regular. Thus, installing 15.8.6 won't be a downgrade; your 15.9 Preview 3 installation will remain.

@pellea
Copy link

pellea commented Oct 23, 2018

@chucker I never installed the regular version. I have only the preview. If there is no possibilities to get this to work with the preview version, I'll then install the regular version.

@chucker
Copy link

chucker commented Oct 25, 2018

@pellea Yup. It's not currently compatible with the 15.9 preview. You'll need to install the regular 15.8.x on the side to test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Bug New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
None yet
Milestone
16.0.P1
Development

No branches or pull requests
9 participants
@chucker @jaredpar @pellea @Craigfis @Suchiman @jmarolf @jinujoseph @jcouv @f2calv