Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up on stack using in fluent invocation binding #33775

Closed
jcouv opened this issue Feb 28, 2019 · 0 comments · Fixed by #33907
Closed

Follow-up on stack using in fluent invocation binding #33775

jcouv opened this issue Feb 28, 2019 · 0 comments · Fixed by #33907
Assignees
@jaredpar
Labels
Area-Compilers New Language Feature - Nullable Reference Types Nullable Reference Types
Milestone
16.1.P1

Comments

@jcouv
Copy link
Member

jcouv commented Feb 28, 2019

As part of PR #33648, I lowered our expectations for how long of a fluent call we can handle (commit a5bc25a).
I didn't manage to figure out which part of the PR might cause this change (greater stack usage during binding).
@jcouv jcouv added this to the 16.1.P1 milestone Feb 28, 2019
@jcouv jcouv mentioned this issue Feb 28, 2019
Merged
@jaredpar jaredpar self-assigned this Mar 6, 2019
@jaredpar jaredpar mentioned this issue Mar 6, 2019
Merged
jaredpar added a commit to jaredpar/roslyn that referenced this issue Mar 7, 2019
@jaredpar
Restore fluent call depth
d6b1a16 
The change to move nullable to a two state solution inadverntently
changed how the CLR inlines a number of method calls. The combination of
not-inlining and over-inlining caused us to have a much larger "frame"
for analyzing a fluent call and exceeded our tolerance levels.

This adjusts the inlining so that we get the same results as before.

closes dotnet#33775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredpar jaredpar

Labels
Area-Compilers New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
None yet
Milestone
16.1.P1
Development

Successfully merging a pull request may close this issue.

Restore fluent call depth jaredpar/roslyn
2 participants
@jaredpar @jcouv