Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uses of AllNullabilityIgnoringSymbolComparer in IMethodSymbolExtensions.RenameTypeParameters #36093

Closed
jasonmalinowski opened this issue May 31, 2019 · 0 comments · Fixed by #40030
Closed

Remove uses of AllNullabilityIgnoringSymbolComparer in IMethodSymbolExtensions.RenameTypeParameters #36093

jasonmalinowski opened this issue May 31, 2019 · 0 comments · Fixed by #40030
Labels
Area-IDE Concept-Continuous Improvement
Milestone
Backlog

Comments

@jasonmalinowski
Copy link
Member

These were added because we have cases where we're passing around unwrapped types but the implementation is doing wrapping. This can be cleaned up once we unify on a final design.
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue Jun 4, 2019
@jasonmalinowski
Add workaround to IMethodSymbolExtensions.RenameTypeParameters
0a90194 
This makes the extension method work again. The workaround is tracked by
dotnet#36093.
@vatsalyaagrawal vatsalyaagrawal added this to the 16.3 milestone Jun 7, 2019
@jinujoseph jinujoseph modified the milestones: 16.3, Backlog Aug 9, 2019
@jasonmalinowski jasonmalinowski mentioned this issue Nov 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Concept-Continuous Improvement
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Remove the nullable wrappers from the Workspaces layer jasonmalinowski/roslyn
3 participants
@jasonmalinowski @vatsalyaagrawal @jinujoseph