Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable IDE Dispose analyzers by default #38984

Closed
mavasani opened this issue Oct 1, 2019 · 1 comment · Fixed by #50303
Closed

Re-enable IDE Dispose analyzers by default #38984

mavasani opened this issue Oct 1, 2019 · 1 comment · Fixed by #50303
Assignees
@mavasani
Labels
Area-IDE Blocked Bug
Milestone
Backlog

Comments

@mavasani
Copy link
Contributor

mavasani commented Oct 1, 2019

We are going to disable the DFA based IDE dispose analyzers (IDE0067, IDE0068 and IDE0069) by default as they need more performance tuning to handle large method bodies (method bodies which are 1000s of lines of code) with large control flow graphs.

Meanwhile, analyzers can be enabled by using the following editorconfig entries:

[*.{cs,vb}]
dotnet_diagnostic.IDE0067.severity = warning
dotnet_diagnostic.IDE0068.severity = warning
dotnet_diagnostic.IDE0069.severity = warning
@mavasani mavasani added this to the Backlog milestone Oct 1, 2019
@mavasani mavasani self-assigned this Oct 1, 2019
mavasani added a commit to mavasani/roslyn that referenced this issue Oct 1, 2019
@mavasani
Disable IDE dispose analyzers by default
956b11b 
We are going to disable the DFA based IDE dispose analyzers (IDE0067, IDE0068 and IDE0069) by default as they need more performance tuning to handle large method bodies (method bodies which are 1000s of lines of code) with large control flow graphs.

dotnet#38984 has been filed to track turning these analyzers back on by default when the issue has been fixed.
@mavasani mavasani mentioned this issue Oct 1, 2019
Merged
@mavasani
Copy link
Contributor Author

mavasani commented Oct 1, 2019 •
edited
Loading

Feedback issues to resolve:

  1. https://developercommunity.visualstudio.com/content/problem/747930/servicehubhostclr-sustained-high-cpu-usage.html
  2. https://developercommunity.visualstudio.com/content/problem/747757/vs-1630-uses-lots-of-cpuram-when-idle-if-certain-p.html
  3. Improve interprocedural analysis performance for DFA analyzers roslyn-analyzers#2750

@mavasani mavasani mentioned this issue Oct 25, 2019
Closed
mavasani added a commit to mavasani/roslyn that referenced this issue Jan 7, 2021
@mavasani
Delete IDE dispose analyzers
da95368 
- These rules have been disabled by default for more than a year now
- These rules were ported from CA rules to IDE rules to enable shipping them in the box. This is no longer required as all CA and IDE rules ship with the .NET SDK now.

Closes dotnet#38984
Closes dotnet#38944
Closes dotnet#38204
Closes dotnet#36507
Closes dotnet#38900
@mavasani mavasani mentioned this issue Jan 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavasani mavasani

Labels
Area-IDE Blocked Bug
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Delete IDE dispose analyzers mavasani/roslyn
1 participant
@mavasani