Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetTypeInfo returns with nullability but the ITypeSymbol.NullableAnnotation is None #40051

Closed
jasonmalinowski opened this issue Nov 28, 2019 · 0 comments · Fixed by #40338
Closed

GetTypeInfo returns with nullability but the ITypeSymbol.NullableAnnotation is None #40051

jasonmalinowski opened this issue Nov 28, 2019 · 0 comments · Fixed by #40338
Assignees
@333fred
Labels
Area-Compilers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - Nullable Reference Types Nullable Reference Types Feature - Nullable Semantic Model Nullable Semantic Model Issues

Comments

@jasonmalinowski
Copy link
Member

This is being observed in #40030 as I'm removing the IDE's nullable wrappers. If you run this test in the branch it fails. The test is calling GetTypeInfo on the argument, and the old nullability APIs say that it is indeed nullable, but the new ITypeSymbol.NullableAnnotation still says None:

image

I believe the expectation now is the ITypeSymbol.NullableAnnotation should have brought along the flow state of Annotated. If I debug into the implementation, it looks like this might just be missing the call to wrap the type.
@jasonmalinowski jasonmalinowski added the Feature - Nullable Semantic Model Nullable Semantic Model Issues label Nov 28, 2019
@gafter gafter added Area-Compilers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. labels Dec 2, 2019
@jcouv jcouv added the Feature - Nullable Reference Types Nullable Reference Types label Dec 11, 2019
AlekseyTs added a commit to AlekseyTs/roslyn that referenced this issue Dec 12, 2019
@AlekseyTs
NullableAnnotation on a type symbol returned by TypeInfo should match…
586d025 
… corresponding FlowState.

Fixes dotnet#40051.
@AlekseyTs AlekseyTs mentioned this issue Dec 12, 2019
Merged
AlekseyTs added a commit that referenced this issue Dec 16, 2019
@AlekseyTs
NullableAnnotation on a type symbol returned by TypeInfo should match…
5badf86 
… corresponding FlowState. (#40338)

Fixes #40051.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@333fred 333fred

Labels
Area-Compilers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - Nullable Reference Types Nullable Reference Types Feature - Nullable Semantic Model Nullable Semantic Model Issues
Projects
None yet
Milestone
No milestone
4 participants
@jasonmalinowski @333fred @gafter @jcouv