Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run analyzers in netcoreapp3.1 build #43969

Closed
RikkiGibson opened this issue May 4, 2020 · 1 comment · Fixed by #43972
Closed

Only run analyzers in netcoreapp3.1 build #43969

RikkiGibson opened this issue May 4, 2020 · 1 comment · Fixed by #43972
Assignees

Comments

@RikkiGibson
Copy link
Contributor

/cc @jaredpar @sharwell

One thing that came up is the most expensive analyzer is code style. Now that we're multi-targeting we're essentially paying that cost twice: once per target framework. Why not condition that to only run on one TF instead of both?

The logic already exists to make this distinction with nullable reference types. Essentially we only enable NRT for a specific TF, not both. We could consider hooking into that for the style based analyzers as well.

@sharwell
Copy link
Member

sharwell commented May 5, 2020

I see no issue with this for code style analyzers.

We should keep our correctness analyzers in all the builds though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants