Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose '$Main' via WellKnownMemberNames #45110

Closed
sharwell opened this issue Jun 12, 2020 · 1 comment · Fixed by #49650
Closed

Expose '$Main' via WellKnownMemberNames #45110

sharwell opened this issue Jun 12, 2020 · 1 comment · Fixed by #49650
Assignees
@sharwell
Labels
Area-IDE Bug Concept-API This issue involves adding, removing, clarification, or modification of an API.
Milestone
Backlog

Comments

@sharwell
Copy link
Member

sharwell commented Jun 12, 2020 •
edited
Loading

Currently we hard-coded $Main as a symbol name:

roslyn/src/Analyzers/Core/Analyzers/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs

Line 699 in 6db6c5e

=> (methodSymbol.Name == WellKnownMemberNames.EntryPointMethodName || methodSymbol.Name == "$Main") &&

We should define a constant in WellKnownMemberNames for this and reference it from the analyzer.

🔗 Originally requested in #45090 (comment)
@sharwell sharwell added Area-Compilers Concept-API This issue involves adding, removing, clarification, or modification of an API. labels Jun 12, 2020
@jaredpar jaredpar added the Bug label Jun 22, 2020
@jaredpar jaredpar added this to the 16.8 milestone Jun 22, 2020
@AlekseyTs AlekseyTs mentioned this issue Jul 12, 2020
Merged
AlekseyTs added a commit to AlekseyTs/roslyn that referenced this issue Jul 14, 2020
@AlekseyTs
Ensure consistent scheme for unspeakable names.
9f56803 
Closes dotnet#45564.
Related to dotnet#45110.
AlekseyTs added a commit that referenced this issue Jul 14, 2020
@AlekseyTs
Ensure consistent scheme for unspeakable names. (#45930)
e2ed258 
Closes #45564.
Related to #45110.
@AlekseyTs
Copy link
Contributor

The constant is added, but I wasn't able to change AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs to use it because it looks like src\CodeStyle\Core\Analyzers\Microsoft.CodeAnalysis.CodeStyle.csproj is not building against the latest version of the WellKnownMemberNames type.

@AlekseyTs AlekseyTs assigned sharwell and unassigned AlekseyTs Jul 14, 2020
@jinujoseph jinujoseph modified the milestones: 16.8, Backlog Nov 12, 2020
@Youssef1313 Youssef1313 mentioned this issue Nov 29, 2020
Merged
@ghost ghost closed this as completed in #49650 Dec 1, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-IDE Bug Concept-API This issue involves adding, removing, clarification, or modification of an API.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Use WellKnownMemberNames.TopLevelStatementsEntryPointMethodName Youssef1313/roslyn
4 participants
@jaredpar @sharwell @AlekseyTs @jinujoseph