Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make field readonly "IDE0044" false positive when used with ref locals #46785

Closed
Youssef1313 opened this issue Aug 13, 2020 · 0 comments · Fixed by #58459
Closed

Make field readonly "IDE0044" false positive when used with ref locals #46785

Youssef1313 opened this issue Aug 13, 2020 · 0 comments · Fixed by #58459
Labels
Area-IDE Bug Feature - IDE0044 Make field readonly IDE-CodeStyle Built-in analyzers, fixes, and refactorings Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
17.1.P3

Comments

@Youssef1313
Copy link
Member

The failing test is added in #45288
@sharwell sharwell changed the title Make field readonly "IDE0044" false positive when used with ref Make field readonly "IDE0044" false positive when used with ref locals Aug 13, 2020
@sharwell sharwell mentioned this issue Aug 13, 2020
Merged
@jinujoseph jinujoseph added Area-IDE Bug IDE-CodeStyle Built-in analyzers, fixes, and refactorings labels Aug 13, 2020
@jinujoseph jinujoseph added this to the 16.8 milestone Aug 13, 2020
@jinujoseph jinujoseph added the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Aug 13, 2020
@jinujoseph jinujoseph modified the milestones: 16.8, Backlog Sep 10, 2020
mavasani added a commit to mavasani/roslyn that referenced this issue Dec 22, 2021
@mavasani
Fix MakeFieldReadonly false positive for ref assignments
e343cb0 
Fixes dotnet#46785
Fixes dotnet#57983
@mavasani mavasani mentioned this issue Dec 22, 2021
Merged
@sharwell sharwell added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented Feature - IDE0044 Make field readonly and removed help wanted The issue is "up for grabs" - add a comment if you are interested in working on it labels May 22, 2023
@sharwell sharwell modified the milestones: Backlog, 17.1.P3 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Bug Feature - IDE0044 Make field readonly IDE-CodeStyle Built-in analyzers, fixes, and refactorings Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
17.1.P3
Development

Successfully merging a pull request may close this issue.

Fix MakeFieldReadonly false positive for ref assignments mavasani/roslyn
3 participants
@sharwell @jinujoseph @Youssef1313