Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record operator parameter names are 'r1' and 'r2' rather than 'left' and 'right' #49300

Closed
jnm2 opened this issue Nov 11, 2020 · 1 comment · Fixed by #51973
Closed

Record operator parameter names are 'r1' and 'r2' rather than 'left' and 'right' #49300

jnm2 opened this issue Nov 11, 2020 · 1 comment · Fixed by #51973
Labels
Area-Compilers help wanted The issue is "up for grabs" - add a comment if you are interested in working on it New Language Feature - Records Records
Milestone
Backlog

Comments

@jnm2
Copy link
Contributor

jnm2 commented Nov 11, 2020 •
edited
Loading

image

According to https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/naming-parameters#naming-operator-overload-parameters, the standard names are left and right. Roslyn IDE fixes currently generate operators with these names as well.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 11, 2020
@jaredpar jaredpar removed the untriaged Issues and PRs which have not yet been triaged by a lead label Nov 17, 2020
@jaredpar jaredpar added this to the Backlog milestone Nov 17, 2020
@RikkiGibson
Copy link
Contributor

This feels like something that's easy to fix, and because labels can't be used for operator arguments, it's not a source breaking change.

@RikkiGibson RikkiGibson added help wanted The issue is "up for grabs" - add a comment if you are interested in working on it New Language Feature - Records Records labels Nov 21, 2020
This was referenced Mar 18, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers help wanted The issue is "up for grabs" - add a comment if you are interested in working on it New Language Feature - Records Records
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Rename record equality parameters to 'left' and 'right' C-xC-c/roslyn
4 participants
@jaredpar @RikkiGibson @jnm2 @Dotnet-GitSync-Bot