-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename record equality parameters to 'left' and 'right' #51973
Conversation
In general, changing parameter names would be a breaking change since callers may use explicit argument names. But I think we're okay because those are operators. We'd need a corresponding update to the spec: |
I have created a pull request for the required spec changes here dotnet/csharplang#4555 |
...mpilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordEqualityOperatorBase.cs
Show resolved
Hide resolved
To reflect changes to record equality operators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (iteration 3)
Planning to merge this afternoon, once we're sure that there's no objection from the language design team. |
Thanks for your contribution @C-xC-c! |
Fixes #49300