Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToDisplayString incorrectly handles function pointers #51222

Closed
YairHalberstadt opened this issue Feb 14, 2021 · 1 comment · Fixed by #51223
Closed

ToDisplayString incorrectly handles function pointers #51222

YairHalberstadt opened this issue Feb 14, 2021 · 1 comment · Fixed by #51223
Assignees
@333fred
Labels
Area-Compilers Bug Feature - Function Pointers Adding Function Pointers
Milestone
16.10

Comments

@YairHalberstadt
Copy link
Contributor

YairHalberstadt commented Feb 14, 2021 •
edited
Loading

Version Used: Microsoft.CodeAnalysis.CSharp.Workspaces 3.8.0

Steps to Reproduce:

  1. Create a IFunctionPointerSymbol representing delegate*<int, string>
  2. Call
type.ToDisplayString(new SymbolDisplayFormat(
     globalNamespaceStyle: SymbolDisplayGlobalNamespaceStyle.Included,
     typeQualificationStyle: SymbolDisplayTypeQualificationStyle.NameAndContainingTypesAndNamespaces,
     genericsOptions: SymbolDisplayGenericsOptions.IncludeTypeParameters)

Expected Behavior: delegate*<global::System.Int32, global::System.String>

Actual Behavior: delegate*<, global::System.String>
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 14, 2021
@YairHalberstadt YairHalberstadt mentioned this issue Feb 14, 2021
Merged
@YairHalberstadt
Copy link
Contributor Author

Fix at #51223

@jaredpar jaredpar added Bug Feature - Function Pointers Adding Function Pointers and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 16, 2021
@jaredpar jaredpar added this to the 16.10 milestone Feb 16, 2021
333fred pushed a commit that referenced this issue Mar 17, 2021
@YairHalberstadt
Fix Function Pointer RefKind Display (#51223)
a6cfe5f 
Fixes #51222
Fixes #51224
@elinor-fung elinor-fung mentioned this issue Apr 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@333fred 333fred

Labels
Area-Compilers Bug Feature - Function Pointers Adding Function Pointers
Projects
None yet
Milestone
16.10
Development

Successfully merging a pull request may close this issue.

Fix Function Pointer RefKind Display YairHalberstadt/roslyn
3 participants
@jaredpar @333fred @YairHalberstadt