Review potential code paths that may or may not need to handle record structs

[Youssef1313]

The order of this list is from things I'm more confident about to things I'm less confident about.

• Add accessibility modifiers analyzer - PR: AddAccessibilityModifiers: record struct support #53633
  

  roslyn/src/Analyzers/CSharp/Analyzers/AddAccessibilityModifiers/CSharpAddAccessibilityModifiersDiagnosticAnalyzer.cs

  Line 58 in 4f5f3e8

  member.IsKind(SyntaxKind.RecordDeclaration, out typeDeclaration))

---

• Handle readonly for symbol display - PR Display 'readonly' for record structs #53634
  

  roslyn/src/Compilers/CSharp/Portable/SymbolDisplay/SymbolDisplayVisitor.Types.cs

  Lines 672 to 677 in 4f5f3e8

  	case TypeKind.Struct when symbol.IsRecord:
  	AddKeyword(SyntaxKind.RecordKeyword);
  	AddSpace();
  	AddKeyword(SyntaxKind.StructKeyword);
  	AddSpace();
  	break;

---

• Does CSharpUseAutoPropertyAnalyzer needs to handle record structs?
  

  roslyn/src/Analyzers/CSharp/Analyzers/UseAutoProperty/CSharpUseAutoPropertyAnalyzer.cs

  Line 56 in 4f5f3e8

  member.IsKind(SyntaxKind.RecordDeclaration, out typeDeclaration))

  
  [jcouv:] Fixed by Fix UseAutoProperty for record structs #56474

---

• Might want to handle for this extension (parameter wrapping depends on this extension, and also doc comments - see Handle records in documentation comments in IDE side #52737) - PR Record structs: Support parameter wrapping and doc comments (IDE) #53640
  

  roslyn/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Extensions/SyntaxNodeExtensions.cs

  Line 260 in bc98ed9

  public static BaseParameterListSyntax? GetParameterList(this SyntaxNode? declaration)

---

---

• Can we reach the following line with a record struct? (add a test if we can) (may be fixed in Fix cref binding on a record with semicolon #53597).
  

  roslyn/src/Compilers/CSharp/Portable/Binder/BinderFactory.cs

  Line 163 in 4f5f3e8

  Debug.Assert(typeDecl.Kind() is SyntaxKind.RecordDeclaration);

---

• Does this need to handle record structs? I'm not aware of how this work tbh.
  

  roslyn/src/Compilers/CSharp/Portable/Compilation/MethodBodySemanticModel.cs

  Line 105 in 4f5f3e8

  case SyntaxKind.RecordDeclaration:

  
  [jcouv:] I don't think this needs to be updated. The only tests affected by this case relate to record base types (BaseArguments_15 for example), which are not relevant to record structs.

---

[Youssef1313]

@jcouv. Feel free to move the appropriate parts of this issue to the test plan and close the issue, or keep it open and link it from the test plan. I'm fine either way.

[jcouv]

It's fine to keep as an issue. Thanks for digging those up.
Linking to test plan #51199

[jcouv]

All bullets were addressed. Closing