Fix UseAutoProperty for record structs #56474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
53
to
+56
| else if (member.IsKind(SyntaxKind.ClassDeclaration, out TypeDeclarationSyntax? typeDeclaration) || | ||
| member.IsKind(SyntaxKind.StructDeclaration, out typeDeclaration) || | ||
| member.IsKind(SyntaxKind.RecordDeclaration, out typeDeclaration)) | ||
| member.IsKind(SyntaxKind.RecordDeclaration, out typeDeclaration) || | ||
| member.IsKind(SyntaxKind.RecordStructDeclaration, out typeDeclaration)) |
There was a problem hiding this comment.
else if (member is TypeDeclarationSyntax typeDeclaration)
There was a problem hiding this comment.
ah, n/m. you're not checking interfaces.
CyrusNajmabadi
approved these changes
Sep 17, 2021
ghost
added this to the
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses last follow-up item from #53631