Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify changes to ConvertOnEnum test #60765

Closed
dibarbet opened this issue Apr 15, 2022 · 2 comments
Closed

Verify changes to ConvertOnEnum test #60765

dibarbet opened this issue Apr 15, 2022 · 2 comments
Labels
Area-Compilers Resolution-By Design The behavior reported in the issue matches the current design

Comments

@dibarbet
Copy link
Member

Changes were made to the C# and VB version of the ConvertOnEnum test as part of the .net 7 upgrade. These changes need to be verified for correctness.

C# - 3c25e89#diff-40a79f7f2b3feb455ff28a9a837a28924f8dab42d627f0aa6aed06a6e756258dR353
VB - 3c25e89#diff-c21a4bd605e74c668a379180c58b139560a2e9c7118a0126a7dff9d4b759c32eL509

Original PR - #60523
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 15, 2022
@Youssef1313
Copy link
Member

Youssef1313 commented Apr 15, 2022 •
edited
Loading

This one has the same reason as #60767, and the baseline change in test looks okay per the runtime change dotnet/runtime#57973 and per Enum.ToString() documentation.

@jcouv
Copy link
Member

jcouv commented Apr 27, 2022

Based on information above (thanks @Youssef1313), the test change is expected and correct. Closing

@jcouv jcouv closed this as completed Apr 27, 2022
@jcouv jcouv added Resolution-By Design The behavior reported in the issue matches the current design and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Resolution-By Design The behavior reported in the issue matches the current design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dibarbet @jcouv @Youssef1313