Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/arcade #60523

Merged
merged 17 commits into from
Apr 19, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 1, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 7e4fe80a-482b-4a41-5b66-08d8d8feb47e
  • Build: 20220415.2
  • Date Produced: April 16, 2022 2:47:34 AM UTC
  • Commit: 4000024394df3049886c50e54ad0a2b903221ef0
  • Branch: refs/heads/main

…331.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22181.2
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner April 1, 2022 12:21
ghost
ghost previously requested changes Apr 1, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR changes the .NET SDK version. Review required from @dotnet/roslyn-infrastructure before merging.
Tasks:

  • Getting Started Documentation has been updated
  • NuGet dependency version updated to match version shipping in SDK

dotnet-maestro bot added 2 commits April 8, 2022 12:21
…406.10

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22206.10
…411.6

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22211.6
…412.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22212.2
dibarbet and others added 4 commits April 13, 2022 15:14
…413.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22213.2
@dibarbet
Copy link
Member

@dotnet/roslyn-compiler - there are a few compiler tests failing with the upgrade to .net7, some potentially related to the runtime change of looking up enum members. Could someone take a look at those tests?

@jasonmalinowski / @chsienki - there is a correctness failure I think related to source generators

##[error]src\Compilers\Test\Core\ModuleInitializer.cs(15,10): error CA2255: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'ModuleInitializer' attribute is only intended to be used in application code or advanced source generator scenarios

Could one of you advise on the correct fix there?

Co-authored-by: Joey Robichaud <jorobich@microsoft.com>
@jasonmalinowski
Copy link
Member

@dibarbet: it looks like that's not really generator related, but rather some analyzer is now telling us not to do what we do here:

[ModuleInitializer]
internal static void Initialize()
{
Trace.Listeners.Clear();
Trace.Listeners.Add(new ThrowingTraceListener());
}

Right fix is probably just to #pragma suppress that.

@AlekseyTs
Copy link
Contributor

@dibarbet

Could someone take a look at those tests?

Where are the details about the failures?

@dibarbet
Copy link
Member

dibarbet commented Apr 14, 2022

@AlekseyTs apologies - my commit triggered a rerun - the test failures should be appearing now.

E.g. (just one example, there are more failures, see the tests tab on ADO)
https://dev.azure.com/dnceng/public/_build/results?buildId=1717786&view=ms.vss-test-web.build-test-results-tab&runId=46664704&resultId=151848&paneView=debug

Microsoft.CodeAnalysis.CSharp.UnitTests.Symbols.Source.EnumTests.ConvertOnEnum
Roslyn.Test.Utilities.ExecutionException :
Execution failed for assembly '86534577-d1f7-47d9-9e2b-9d3065a73668, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null'.
Expected:
ValueE
-1

Actual: ValueB
-1

@AlekseyTs
Copy link
Contributor

For compiler tests, I suggest:

  • updating baselines for tests that fail due to a baseline diff and opening an issue to follow up/confirm the change.
  • disabling tests that fail due to other reasons and opening an issue to follow up.

@dibarbet
Copy link
Member

For compiler tests, I suggest:

  • updating baselines for tests that fail due to a baseline diff and opening an issue to follow up/confirm the change.
  • disabling tests that fail due to other reasons and opening an issue to follow up.

Thanks - will do!

…414.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22214.3
…415.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22215.1
…415.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22215.2
@dibarbet dibarbet dismissed ghost ’s stale review April 19, 2022 01:06

no longer applicable, updated docs

@dibarbet dibarbet merged commit 3c00d86 into main Apr 19, 2022
@dibarbet dibarbet deleted the darc-main-7af0f9af-83d6-461c-9be0-5a7df61c07f0 branch April 19, 2022 01:06
@ghost ghost added this to the Next milestone Apr 19, 2022
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
JoeRobich added a commit that referenced this pull request May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants