Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer summary should show suppressor ID #69628

Closed
Youssef1313 opened this issue Aug 19, 2023 · 2 comments · Fixed by #72569
Closed

Analyzer summary should show suppressor ID #69628

Youssef1313 opened this issue Aug 19, 2023 · 2 comments · Fixed by #72569
Assignees
@mavasani @SimonZhao0512
Labels
Area-Analyzers Feature Request good first issue The issue is reserved for a first time, non-Microsoft contributor help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone
18.0

Comments

@Youssef1313
Copy link
Member

image

Currently, only DiagnosticAnalyzer.SupportedDiagnostics is handled. However, DiagnosticSuppressor.SupportedSuppressions is not.

The support to show diagnostic IDs was added in #51696. This PR should help a community contributor to know where he should look into :)
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 19, 2023
@arunchndr arunchndr added this to the 18.0 milestone Aug 21, 2023
@arunchndr arunchndr added Feature Request and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 21, 2023
@mavasani mavasani added help wanted The issue is "up for grabs" - add a comment if you are interested in working on it good first issue The issue is reserved for a first time, non-Microsoft contributor labels Nov 2, 2023
@SimonZhao0512
Copy link

SimonZhao0512 commented Nov 11, 2023 •
edited
Loading

Hi @mavasani, I see this issue has been assigned to you, but I haven't seen any activity here in a while. If you still need help, can I work on this?

@mavasani
Copy link
Contributor

@SimonZhao0512 Definitely, go for it.

@juan-carlos-diaz juan-carlos-diaz mentioned this issue Mar 15, 2024
Merged
@Kore-rep Kore-rep mentioned this issue Mar 16, 2024
Closed
333fred pushed a commit that referenced this issue Mar 20, 2024
@juan-carlos-diaz @juan-diaz-at-nicklaus
Fix #69628 Analyzer summary should show suppressor ID (#72569)
20f2319 
* Show suppressor ids in analyser report

* Reuse old test

---------

Co-authored-by: Juan C. Diaz <juan.diaz@nicklaushealth.org>
333fred added a commit that referenced this issue Mar 20, 2024
@333fred
Merge remote-tracking branch 'upstream/main' into demo/razor-lexer
460e5e4 
* upstream/main: (1045 commits)
  Fix excessive compilation times due to speculative parsing after an incomplete string (#72565)
  Convert official pipeline to 1ES template (#72430)
  Fix #69628 Analyzer summary should show suppressor ID (#72569)
  Fix event hookup even when in a projection buffer
  Drop win32-ia32 language server support
  Remove workaround for .net7 r2r assembly loading issue
  remove unused usings
  Share compilation when generators don't produce any generated files
  Fix potential exception in AssetProvider.SynchronizeAssetsAsync (#72597)
  Fix
  Update __arglist.md (#72523)
  Improve code gen for concatenation of `string` and `char` (#71793)
  Reduce File I/O under the AnalyzerAssemblyLoader folder (#72412)
  Reduce allocations in AbstractTypeMap (#72588)
  disable diagnostics when solution crawler option is disabled
  disable diagnostics when solution crawler option is disabled
  better thread transitions
  Fix
  Add check
  Fix
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavasani mavasani

@SimonZhao0512 SimonZhao0512

Labels
Area-Analyzers Feature Request good first issue The issue is reserved for a first time, non-Microsoft contributor help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
None yet
Milestone
18.0
Development

Successfully merging a pull request may close this issue.

Fix #69628 Analyzer summary should show suppressor ID juan-carlos-diaz/roslyn
4 participants
@mavasani @Youssef1313 @SimonZhao0512 @arunchndr