Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler doesn't produce either FieldReferenceExpression or PropertyReferenceExpression for events. #7587

Closed
brettfo opened this issue Dec 18, 2015 · 1 comment
Closed

Compiler doesn't produce either FieldReferenceExpression or PropertyReferenceExpression for events. #7587

brettfo opened this issue Dec 18, 2015 · 1 comment
Labels
Area-Compilers Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented Verified

Comments

@brettfo
Copy link
Member

brettfo commented Dec 18, 2015

Similar to #7584, events don't generate any IOperations.

FYI @CyrusNajmabadi @JohnHamby
@brettfo brettfo mentioned this issue Dec 18, 2015
Closed
@CyrusNajmabadi
Copy link
Member

Note: events seem so first class that I would expect the IOperation level to have some sort of IEventAccessExpression. That type could then point to the specific field/property that was actually being referenced.

I think this would be appropriate given how special events are and how they even have first class operations in the language for manipulating them (i.e. += and -=)

@msJohnHamby msJohnHamby mentioned this issue Dec 23, 2015
Merged
brettfo added a commit to brettfo/roslyn that referenced this issue Jan 6, 2016
@brettfo
convert analyzer to be IOperation-based
bfc3643 
Due to issues dotnet#7584 and dotnet#7587 adding `this.`/`Me.` is disabled for
methods and events.

Also add tests for verifying that no diagnostics are generated for static
access or `base`/`MyBase` access.
brettfo added a commit to brettfo/roslyn that referenced this issue Feb 26, 2016
@brettfo
convert analyzer to be IOperation-based
eb954db 
Due to issues dotnet#7584 and dotnet#7587 adding `this.`/`Me.` is disabled for
methods and events.

Also add tests for verifying that no diagnostics are generated for static
access or `base`/`MyBase` access.
@msJohnHamby msJohnHamby added the Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented label Mar 16, 2016
@msJohnHamby msJohnHamby assigned brettfo and unassigned msJohnHamby Mar 16, 2016
@brettfo brettfo removed their assignment Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented Verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettfo @CyrusNajmabadi @msJohnHamby