Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconstruct method if any type arguments are error types #10656

Merged
merged 1 commit into from
May 16, 2016

Conversation

bmay2
Copy link
Contributor

@bmay2 bmay2 commented Apr 18, 2016

Fixes #1903

@Pilchie Pilchie added Community The pull request was submitted by a contributor who is not a Microsoft employee. Area-IDE labels May 15, 2016
@Pilchie
Copy link
Member

Pilchie commented May 15, 2016

Tag @dotnet/roslyn-ide for review.

@dotnet-bot test vsi please.

@Pilchie
Copy link
Member

Pilchie commented May 15, 2016

@CyrusNajmabadi in particular might want to take a look at this.

@CyrusNajmabadi
Copy link
Member

👍

@Pilchie
Copy link
Member

Pilchie commented May 16, 2016

Any chance this makes things worse in cases where some of the constructed arguments would have been better matches?

@CyrusNajmabadi
Copy link
Member

Any chance this makes things worse

Really hard to say. We have a reasonably good test bed for type inference (both directly, and through lots of refactoring tests). That nothing even changed is a good sign.

@balajikris
Copy link
Member

👍

@balajikris
Copy link
Member

@Pilchie I'm ready to merge this in, if your concerns have eased?

@Pilchie
Copy link
Member

Pilchie commented May 16, 2016

Yes, let's go! :shipit:

@balajikris balajikris merged commit b3156f4 into dotnet:master May 16, 2016
@balajikris
Copy link
Member

@bmay2 thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE cla-already-signed Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants