Test that tuples should not be part of patterns #11012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
added
Area-Compilers
New Language Feature - Pattern Matching
| comp.VerifyDiagnostics( | ||
| // (6,18): error CS0150: A constant value is expected | ||
| // if (o is (1, 2)) | ||
| Diagnostic(ErrorCode.ERR_ConstantExpected, "(1, 2)").WithLocation(6, 18) |
There was a problem hiding this comment.
This one is a little worrying. It suggests that (1, 2) is being parsed as a tuple expression, which should not be possible in this context. But that will have to be sorted out later when we parse tuple patterns.
|
LGTM |
|
@VSadov @dotnet/roslyn-compiler for a second review. |
|
@VSadov for a second review. This one is pretty simple. |
|
LGTM |
|
@dotnet-bot Test prtest/lin/dbg/unit32 please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gafter for first review.