Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring /errorlog output up to SARIF draft 1.0.0-beta.5 #11233

Merged
merged 11 commits into from
May 17, 2016
Merged

Bring /errorlog output up to SARIF draft 1.0.0-beta.5 #11233

merged 11 commits into from
May 17, 2016

Commits on May 13, 2016

  1. Stop escaping forward slashes in /errorlog JSON output 

    JSON spec makes escaping of forward slashes optional and many have
complained about the aesthetics of '\/'. Previously, we got this
behavior from the DataContractJsonSerializer and could not override
it, but now that the dependency has been removed, we can eliminate
the unnecessary escaping.
    @nguerrera
    nguerrera committed May 13, 2016
    Configuration menu
    Copy the full SHA
    a0aa036 View commit details
    Browse the repository at this point in the history

  2. Weaken JsonWriter's StreamWriter dependency to TextWriter 

    Also, defer to TextWriter for NewLine character rather than
hard-coding Environment.NewLine.
    @nguerrera
    nguerrera committed May 13, 2016
    Configuration menu
    Copy the full SHA
    1851e12 View commit details
    Browse the repository at this point in the history

  3. Add JSON escaping tests

    @nguerrera
    nguerrera committed May 13, 2016
    Configuration menu
    Copy the full SHA
    10e1a9b View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary special-case for "'" in JsonWriter 

    Also remove outdated future improvement comment
    @nguerrera
    nguerrera committed May 13, 2016
    Configuration menu
    Copy the full SHA
    450f6fe View commit details
    Browse the repository at this point in the history

  5. Bring /errorlog output up to SARIF draft 1.0.0-beta.4

    @nguerrera
    nguerrera committed May 13, 2016
    Configuration menu
    Copy the full SHA
    fe02e3f View commit details
    Browse the repository at this point in the history

  6. Log rule metadata in /errorlog in official way

    @nguerrera
    nguerrera committed May 13, 2016
    Configuration menu
    Copy the full SHA
    3826c36 View commit details
    Browse the repository at this point in the history

  7. Bring /errorlog output up to SARIF draft 1.0.0-beta.5

    @nguerrera
    nguerrera committed May 13, 2016
    Configuration menu
    Copy the full SHA
    1670e1d View commit details
    Browse the repository at this point in the history

  8. Deal with corner case in rule key collision

    @nguerrera
    nguerrera committed May 13, 2016
    Configuration menu
    Copy the full SHA
    41acd32 View commit details
    Browse the repository at this point in the history

  9. Change "analysisTarget" to "resultFile" in SARIF output

    @nguerrera
    nguerrera committed May 13, 2016
    Configuration menu
    Copy the full SHA
    5ae04f6 View commit details
    Browse the repository at this point in the history

  10. Add ErrorLogger tests for related locations and ID collision 

    Also make ErrorLogger tolerate "external" locations.
    @nguerrera
    nguerrera committed May 13, 2016
    Configuration menu
    Copy the full SHA
    f26c807 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2016

  1. Update /errorlog doc

    @nguerrera
    nguerrera committed May 16, 2016
    Configuration menu
    Copy the full SHA
    a8dde7e View commit details
    Browse the repository at this point in the history