Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find dependent types more efficiently by storing inheritance info directly in our indices. #11313

Merged
merged 73 commits into from
May 17, 2016
Merged

Find dependent types more efficiently by storing inheritance info directly in our indices. #11313

merged 73 commits into from
May 17, 2016

Commits on May 12, 2016

  1. Store inforation in DeclaredSymbolInfo about what type names the type… 

    … says it inherits/implements.
    @CyrusNajmabadi
    CyrusNajmabadi committed May 12, 2016
    Configuration menu
    Copy the full SHA
    cdd6ae2 View commit details
    Browse the repository at this point in the history

  2. Improve the implementation of GetTypesImmediatelyDerivedFromClassesAs… 

    …ync by creating far less source symbols when searching for matches.
    @CyrusNajmabadi
    CyrusNajmabadi committed May 12, 2016
    Configuration menu
    Copy the full SHA
    05edce6 View commit details
    Browse the repository at this point in the history

  3. Simplify code.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 12, 2016
    Configuration menu
    Copy the full SHA
    7b3f3fc View commit details
    Browse the repository at this point in the history

  4. Simplify code.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 12, 2016
    Configuration menu
    Copy the full SHA
    2b53f67 View commit details
    Browse the repository at this point in the history

  5. Switch interface searching to use the same declaration map.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 12, 2016
    Configuration menu
    Copy the full SHA
    34cfbc8 View commit details
    Browse the repository at this point in the history

  6. Stop using MoveToImmutable.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 12, 2016
    Configuration menu
    Copy the full SHA
    3231d5c View commit details
    Browse the repository at this point in the history

  7. Keep track of aliases, and use them to augment the list of inheritanc… 

    …e names we store for a type.
    @CyrusNajmabadi
    CyrusNajmabadi committed May 12, 2016
    Configuration menu
    Copy the full SHA
    1bc2a33 View commit details
    Browse the repository at this point in the history

  8. Handle when there are aliases in the inheritance list points to those… 

    … aliases.
    @CyrusNajmabadi
    CyrusNajmabadi committed May 12, 2016
    Configuration menu
    Copy the full SHA
    895aae8 View commit details
    Browse the repository at this point in the history

  9. Check to make sure there is actually a base list before continuing.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 12, 2016
    Configuration menu
    Copy the full SHA
    db529bb View commit details
    Browse the repository at this point in the history

Commits on May 13, 2016

  1. Fix issue where we weren't properly creating the DeclaredTypeInfo for… 

    … VB types.
    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    a0b4ae8 View commit details
    Browse the repository at this point in the history

  2. Add test for finding derived types, even when aliases are involved.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    0f10675 View commit details
    Browse the repository at this point in the history

  3. Don't search for derived types for sealed types.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    e530f35 View commit details
    Browse the repository at this point in the history

  4. Build FindDerivedClassesAsync on top of GetTypesImmediatelyDerivedFro… 

    …mClassesAsync
    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    5899191 View commit details
    Browse the repository at this point in the history

  5. Build FindImplementingTypesAsync on top of GetTypesImmediatelyDerived… 

    …FromInterfacesAsync and FindDerivedClassesAsync
    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    b7cbe4b View commit details
    Browse the repository at this point in the history

  6. Remove unused method.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    9dc1d81 View commit details
    Browse the repository at this point in the history

  7. Remove method.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    2a64e25 View commit details
    Browse the repository at this point in the history

  8. Remove method.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    e22be5c View commit details
    Browse the repository at this point in the history

  9. Remove method.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    00aab8f View commit details
    Browse the repository at this point in the history

  10. Remove unused methods.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    38fc108 View commit details
    Browse the repository at this point in the history

  11. Remove unused fields.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    7d9d0aa View commit details
    Browse the repository at this point in the history

  12. Move fields.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    c000f95 View commit details
    Browse the repository at this point in the history

  13. Properly pass the project collection around.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    079b33e View commit details
    Browse the repository at this point in the history

  14. Don't add structs to the class queue.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    c7d1078 View commit details
    Browse the repository at this point in the history

  15. Use simple comparison for type equality.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    e43b127 View commit details
    Browse the repository at this point in the history

  16. Remove dead code.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 13, 2016
    Configuration menu
    Copy the full SHA
    a52813b View commit details
    Browse the repository at this point in the history

Commits on May 14, 2016

  1. Cache semantic models as we walk the projects.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 14, 2016
    Configuration menu
    Copy the full SHA
    907cdfe View commit details
    Browse the repository at this point in the history

  2. Process one project at a time.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 14, 2016
    Configuration menu
    Copy the full SHA
    7e69ca2 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2016

  1. Flesh out metadata reading

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    3e7ebcf View commit details
    Browse the repository at this point in the history

  2. More refactoring to search a single project at a time.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    96810ec View commit details
    Browse the repository at this point in the history

  3. Process each project in order.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    dba9b28 View commit details
    Browse the repository at this point in the history

  4. Name members more clearly.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    deb4fe3 View commit details
    Browse the repository at this point in the history

  5. Rename method.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    f70f829 View commit details
    Browse the repository at this point in the history

  6. Remove unused method.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    bb4137c View commit details
    Browse the repository at this point in the history

  7. Rename method.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    4bf06cc View commit details
    Browse the repository at this point in the history

  8. Fix null refs.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    bdf09da View commit details
    Browse the repository at this point in the history

  9. Fix null ref.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    091d664 View commit details
    Browse the repository at this point in the history

  10. Make method into a delegate.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    386df78 View commit details
    Browse the repository at this point in the history

  11. Rename local.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    6692376 View commit details
    Browse the repository at this point in the history

  12. Properly search for special types.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    0f13e98 View commit details
    Browse the repository at this point in the history

  13. Pass along a flag to demarcate transitive or non-transitive searching.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    b366740 View commit details
    Browse the repository at this point in the history

  14. Build the immediate functions on top of the basic functions.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    445e325 View commit details
    Browse the repository at this point in the history

  15. Expose proper semantics.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    2f73524 View commit details
    Browse the repository at this point in the history

  16. Actually return result.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    6dc136f View commit details
    Browse the repository at this point in the history

  17. properly pass along argument.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    a16a09c View commit details
    Browse the repository at this point in the history

  18. Need these caches to eb concurrency safe as we process documents in p… 

    …arallel.
    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    ed984a5 View commit details
    Browse the repository at this point in the history

  19. Fix topological ordering of projects.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    fed0a33 View commit details
    Browse the repository at this point in the history

  20. Cache teh top level declaration info, not all the child infos.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    78131a7 View commit details
    Browse the repository at this point in the history

  21. Move methods out of DependentTypeFinder. They're not used there anymore.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 15, 2016
    Configuration menu
    Copy the full SHA
    0f087bf View commit details
    Browse the repository at this point in the history

Commits on May 16, 2016

  1. PR feedback.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    05f17f2 View commit details
    Browse the repository at this point in the history

  2. Inline methods.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    ca411a8 View commit details
    Browse the repository at this point in the history

  3. Set an initial capacity on our dictionary.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    37b9999 View commit details
    Browse the repository at this point in the history

  4. Rename method.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    419e2d9 View commit details
    Browse the repository at this point in the history

  5. Inline methods.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    993c2d5 View commit details
    Browse the repository at this point in the history

  6. Rename static field.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    2f3e1ab View commit details
    Browse the repository at this point in the history

  7. Remove unused type.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    302c924 View commit details
    Browse the repository at this point in the history

  8. Make types nested and private.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    3e6558e View commit details
    Browse the repository at this point in the history

  9. Clarify code.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    653d1bd View commit details
    Browse the repository at this point in the history

  10. Inline methods.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    8f704c1 View commit details
    Browse the repository at this point in the history

  11. Inline methods.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    4e96456 View commit details
    Browse the repository at this point in the history

  12. Remove unused delegate types.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    5632828 View commit details
    Browse the repository at this point in the history

  13. Move method to delegate.'

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    b19cb19 View commit details
    Browse the repository at this point in the history

  14. Reorder parameters.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    942c751 View commit details
    Browse the repository at this point in the history

  15. Inline initialization.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    0aef7d4 View commit details
    Browse the repository at this point in the history

  16. Make an n^2 loop into O(n)

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    d377f78 View commit details
    Browse the repository at this point in the history

  17. Make loop O(n)

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    33be43f View commit details
    Browse the repository at this point in the history

  18. Add named parameters

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    253eb57 View commit details
    Browse the repository at this point in the history

  19. Add comments.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    01a74a2 View commit details
    Browse the repository at this point in the history

  20. Remove unnecessary code.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    a6e2bea View commit details
    Browse the repository at this point in the history

  21. Comment code.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    e1be5c9 View commit details
    Browse the repository at this point in the history

  22. Comment code.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    77c293e View commit details
    Browse the repository at this point in the history

  23. Add comments.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 16, 2016
    Configuration menu
    Copy the full SHA
    31acc1f View commit details
    Browse the repository at this point in the history

Commits on May 17, 2016

  1. Rename parameters.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 17, 2016
    Configuration menu
    Copy the full SHA
    28f6f3e View commit details
    Browse the repository at this point in the history

  2. Rename type.

    @CyrusNajmabadi
    CyrusNajmabadi committed May 17, 2016
    Configuration menu
    Copy the full SHA
    0662815 View commit details
    Browse the repository at this point in the history