Fix a flaky compiler suite #11514
Merged
Fix a flaky compiler suite #11514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @dotnet/roslyn-compiler, @MattGertz |
|
No ask mode approval needed for test-only fixes, but the commit also touches code files, yes? Either way, approved. |
|
@MattGertz yes this touches code paths (albeit in a very minor way). |
|
@jaredpar It looks like build failure on windows is related to the change you are making. |
The intent of ServerRespectsAppConfig was to verify the server actually read the default timeout value from the application configuration file. The test validated this in a very indirect way: - Changing the value in app.config - Starting the server - Verifying it stopped in the given time frame This can fail for a number of reasons: computer load during the test, another process communicating with the server, etc ... Changed the test to just directly test the value being read from application settings. Justification for ask mode: this test was flaky enough to break signed builds.
|
@AlekseyTs oops, yep that's my fault. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of ServerRespectsAppConfig was to verify the server actually read the default timeout value from the application configuration file. The test validated this in a very indirect way:
This can fail for a number of reasons: computer load during the test, another process communicating with the server, etc ...
Changed the test to just directly test the value being read from application settings.
Justification for ask mode: this test was flaky enough to break signed builds.