Replace property with method #11549
Merged
Replace property with method #11549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
added
PR For Personal Review Only
CyrusNajmabadi
removed
the
PR For Personal Review Only
|
tagging @dotnet/roslyn-ide This is ready for review. Thanks! |
|
retest vsi please |
| } | ||
|
|
||
| [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsReplacePropertyWithMethods)] | ||
| public async Task TestAutoProperty5() |
There was a problem hiding this comment.
Expression bodied properties, and properties with different access levels for their get and set methods?
There was a problem hiding this comment.
There are tests for hte former. But i will add tests for the latter. thanks!
| // the case for C# where we have mangled names for the backing field and need something | ||
| // actually usable in code. | ||
| var uniqueName = NameGenerator.GenerateUniqueName( | ||
| property.Name.ToLowerInvariant(), |
There was a problem hiding this comment.
We probably don't want to lowercase everything - just the first character?
|
Looks pretty good to me with fixes for the above comments. |
|
test vsi please |
|
retest windows_vsi_p1_open_prtest please |
|
retest windows_vsi_p2_open_prtest please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new refactoring where you can take an property and convert it to Get/Set methods.