Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port https://github.com/dotnet/roslyn/pull/11398 over to SymbolKeys. … #11561

Merged
merged 1 commit into from
May 25, 2016
Merged

Port https://github.com/dotnet/roslyn/pull/11398 over to SymbolKeys. … #11561

merged 1 commit into from
May 25, 2016

Conversation

CyrusNajmabadi
Copy link
Member

The previous fix only addressed symbol ids.

@CyrusNajmabadi
Copy link
Member Author

tagging @dotnet/roslyn-ide

@rchande
Copy link
Contributor

rchande commented May 25, 2016

👍
I added test for SymbolId, is that worth porting too?

@jasonmalinowski
Copy link
Member

👍

@jasonmalinowski
Copy link
Member

@dotnet-bot test vsi please.

@CyrusNajmabadi CyrusNajmabadi merged commit 5ae94f2 into dotnet:master May 25, 2016
@CyrusNajmabadi CyrusNajmabadi deleted the symbolKeyCrash branch May 25, 2016 23:01
@CyrusNajmabadi CyrusNajmabadi restored the symbolKeyCrash branch May 30, 2016 21:04
@CyrusNajmabadi CyrusNajmabadi deleted the symbolKeyCrash branch January 25, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CyrusNajmabadi @rchande @jasonmalinowski @dnfclas