Make compiler familiar with TH2 format of DeprecatedAttribute. #11589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far compiler knows about the following signatures of DeprecatedAttribute constructor.
DeprecatedAttribute(String, DeprecationType, UInt32)
DeprecatedAttribute(String, DeprecationType, UInt32, Platform)
DeprecatedAttribute(String, DeprecationType, UInt32, Type)
As of TH2 and onwards Windows SDK uses the following signature for the DeprecatedAttribute:
DeprecatedAttribute(String, DeprecationType, UInt32, String)
Notice the "String" at the end of the signature.
This change adds the TH2 attribute signature to the known set.
Fixes: dotnet#10630
|
@dotnet/roslyn-compiler - please review |
|
Approved pending CRs. |
| @@ -7510,6 +7512,93 @@ static void Main(string[] args) | |||
| ); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void TestDeprecatedAttributeTH2() | |||
There was a problem hiding this comment.
Consider adding similar test for VB.
|
LGTM |
|
Need one more review please |
|
Looking at this now. |
|
LGTM, thanks! |
|
@jcouv Threshold, I think. |
This was referenced May 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far compiler knows about the following signatures of DeprecatedAttribute constructor.
DeprecatedAttribute(String, DeprecationType, UInt32)
DeprecatedAttribute(String, DeprecationType, UInt32, Platform)
DeprecatedAttribute(String, DeprecationType, UInt32, Type)
As of TH2 and onwards Windows SDK uses the following signature for the DeprecatedAttribute:
Notice the "String" at the end of the signature.
This change adds the TH2 attribute signature to the known set.
Fixes: #10630