-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vb language version 15 to command line parser #11670
Conversation
LGTM |
Thanks @AlekseyTs! @dotnet/roslyn-compiler: one more review please! It's small, I promise! |
@@ -100,7 +100,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic | |||
Dim parseDocumentationComments As Boolean = False ' Don't just null check documentationFileName because we want to do this even if the file name is invalid. | |||
Dim outputKind As OutputKind = OutputKind.ConsoleApplication | |||
Dim ssVersion As SubsystemVersion = SubsystemVersion.None | |||
Dim languageVersion As LanguageVersion = LanguageVersion.VisualBasic14 | |||
Dim languageVersion As LanguageVersion = languageVersion.VisualBasic15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LanguageVersion.VisualBasic15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not like VB is case-sensitive. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lAnGuAgEvErSiOn it is then!
LGTM |
Sister-pr to #11660
@dotnet/roslyn-compiler