Suppress dynamic access to instance indexers off of types. #11677
Conversation
AlekseyTs
added
Language-C#
Area-Compilers
Tenet-Reliability
AlekseyTs
removed
the
PR For Personal Review Only
|
@dotnet/roslyn-compiler Please review Update 3 fix. CC @MattGertz, @jaredpar For ask mode approval. |
|
Ping. @dotnet/roslyn-compiler Please review Update 3 fix. CC @MattGertz, @jaredpar For ask mode approval. |
|
Pending CRs. |
|
|
||
| [ClrOnlyFact(ClrOnlyReason.Ilasm)] | ||
| [WorkItem(204561, "https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?id=204561&_a=edit")] | ||
| public void Bug204561_01() |
There was a problem hiding this comment.
Perhaps name the tests SuppressDynamicIndexerAccess or something similar.
|
LGTM |
|
@dotnet/roslyn-compiler Please review Update 3 fix, I need a second sign-off. |
| } // end of class WithIndexer | ||
| "; | ||
|
|
||
| MetadataReference reference = CompileIL(iLSource, appendDefaultHeader: true, embedInteropTypes: false); |
There was a problem hiding this comment.
Can an assembly of this structure only be created in IL? Just asking because if it could also be created in VB it may be interesting to have a test with VB code to ensure reasonable interop.
There was a problem hiding this comment.
I prefer to test from IL in this case. As you can see, there is no interop with indexed property in this case and that is the scenario we are interested about.
There was a problem hiding this comment.
Yeah, I suppose producing a binding error isn't interop. Sounds good.
|
LGTM |
|
Renamed unit-tests. |
Fixes some of the scenarios for https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?id=204561&_a=edit.