Provide a synchronous path for outlining so it won't block hte UI thread waiting for a threadpool thread. #11705
Conversation
…ead waiting for a threadpool thread.
|
Tagging @dotnet/roslyn-ide . This helps address a regression where we are being asked to synchronously compute outlining spans on the UI thread, but we end up blocking the UI thread waiting for a threadpool thread to get around to processing the operation for us. |
|
retest vsi please |
|
@jasonmalinowski Plz review this for Ask mode. |
| @@ -227,6 +257,22 @@ public bool TryGetSyntaxRoot(out SyntaxNode root) | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Only for features that absolutely must run synchronously (probably because they're | |||
| /// on the UI thread). Right now, the only feature this is for is Outlining as VS will | |||
There was a problem hiding this comment.
Should we not have the "right now..." comment, since I can imagine that quickly getting out of sync? Is it worth auditing our codebase for a .GetSyntaxTreeAsync().Result and moving others over? I could imagine this would also have improvements for some automatic formatting stuff which might be worth getting the benefit of.
|
Overall, 👍. The caching of SyntaxTree tasks you've observed seems terribly fishy to me and I think might warrant further investigation, but clearly you didn't make that part worse. Is it worth going through and seeing what other taggers can cheaply be moved over to this? |
No description provided.