Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed Nameof usage in Update SyntaxList`1.cs #11774

Merged
merged 1 commit into from
Jun 15, 2016

Conversation

AdamSpeight2008
Copy link
Contributor

Utilise nameof

Utilise `nameof`
@AdamSpeight2008 AdamSpeight2008 changed the title Update SyntaxList`1.cs Missed Nameof usage in Update SyntaxList1.cs` Jun 5, 2016
@AdamSpeight2008 AdamSpeight2008 changed the title Missed Nameof usage in Update SyntaxList1.cs` Missed Nameof usage in Update SyntaxList`1.cs Jun 5, 2016
@gafter gafter added Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Jun 5, 2016
@gafter
Copy link
Member

gafter commented Jun 14, 2016

LGTM

@AlekseyTs Can you please check this?

@gafter gafter self-assigned this Jun 14, 2016
@AlekseyTs
Copy link
Contributor

LGTM

@AdamSpeight2008
Copy link
Contributor Author

Just happened to spot this whilst I step through the code, so thought I put in an tiny PR for it.
Is it OK to put in small PR like this one? Should I spot others.

@AlekseyTs AlekseyTs merged commit 9a0f09d into dotnet:master Jun 15, 2016
@AlekseyTs
Copy link
Contributor

@AdamSpeight2008 Thanks for the contribution! The size of the PR is fine and submitting PRs for similar changes is fine too.

@AdamSpeight2008 AdamSpeight2008 deleted the patch-2 branch June 16, 2016 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers cla-already-signed Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants