Merge microupdate 3.2 into microupdate #12229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first one is preview workspace leak due to diagnostic service hold onto workspace. second is capturing project in diagnostic exception handler
Use nuget.exe 3.5.0.1484
This commit makes it so that we will always try to generate release nugets except if they depend on prerelease packages. If one of our nuget packages happens to depend on prerelease packages, then when building release nugets, we will simply print a message in the build output and skip release nuget generation for that package (and allow the overall build to succeed).
… instead of adding custom logic in the script for this.
Only compute entry points when compiling everything.
fixed 2 memory leaks
Enable release nugets in microupdate-3.2 branch
this leak was responsible for about 14% of managed memory in customer's dump. basically, in certain condition, if cancellation exception is thrown, we will not close difference viewer which cause all text views to leak. that cause all taggers and text buffers to leak and that cause our preview workspaces to alive. which in turn cause all solutions to alive and so on. all those objects (view, buffer, workspace, solution) are quite big graphs. so ends up eat up 14% of memory. added assert to make sure if we leak viewers again, we get some kind of notification.
fixed DifferenceViewer leak
jasonmalinowski
force-pushed
the
merge-microupdate-3.2-into-microupdate
branch
from
5d14e88
to
6ca51bc
Compare
jasonmalinowski
force-pushed
the
merge-microupdate-3.2-into-microupdate
branch
from
6ca51bc
to
a59f56e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is merging the stuff we had in our temporary staging branch back into our real microupdate branch.
Note: this also contains the bump to 1.3.3 for NuGet package versions
Review: @dotnet/roslyn-infrastructure, @MattGertz for at least an FYI if not formal approval