-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report errors for new features unsupported in expression trees. #12941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gafter
added
New Language Feature - Pattern Matching
Pattern Matching
New Language Feature - Tuples
Tuples
New Language Feature - Out Variable Declaration
Out Variable Declaration
Bug
labels
Aug 4, 2016
break; | ||
case BoundKind.Local: | ||
var local = (BoundLocal)argument; | ||
if (local.Syntax is Syntax.DeclarationExpressionSyntax) CheckOutDeclaration(local, method); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (local.Syntax.Kind() == SyntaxKind.DeclarationExpression)
LGTM |
@VSadov Could you check this PR please? |
@VSadov Could you check this PR please? |
LGTM |
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved to merge
Area-Compilers
Bug
cla-already-signed
New Language Feature - Out Variable Declaration
Out Variable Declaration
New Language Feature - Pattern Matching
Pattern Matching
New Language Feature - Tuples
Tuples
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12900
@dotnet/roslyn-compiler Please review.