Add LanguageServiceRegistrationFiles back #13369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| installationElement.Attribute("Experimental")?.Remove() | ||
|
|
||
| ' Update the path to our MEF/Analyzer Components to be in their new home under PrivateAssemblies | ||
| Dim assets = From asset In xml...<vsix:Asset> |
There was a problem hiding this comment.
Don't know. I just rolled back to code that was there before. I assume it means enumerate all nodes <vsix:Assert> in the descendants of xml?
There was a problem hiding this comment.
that it is a rollback slightly alleviates my fear of what this is doing, but still 😢
There was a problem hiding this comment.
Yes, that's what that syntax means.
|
I don't know this code up close, but if this entire change is just a rollback of a previous commit and nothing new was added, 👍 If not, someone who is familiar with this code should review this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went too far with legacy setup files removal in #13306.
Turns out we still need to include LanguageServiceRegistrationFiles in each insertion as the files contain build version.