Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Arbitrary async returns" should use attribute #13405

Merged
merged 19 commits into from
Sep 6, 2016
Merged

"Arbitrary async returns" should use attribute #13405

merged 19 commits into from
Sep 6, 2016

Commits on May 25, 2016

  1. Merge pull request #1 from dotnet/master 

    Bring ljw1004 fork up to date
    @ljw1004
    ljw1004 committed May 25, 2016
    Configuration menu
    Copy the full SHA
    b82a3f9 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2016

  1. Merge pull request #2 from dotnet/master 

    FI into ljw1004/roslyn
    @ljw1004
    ljw1004 committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    1c806ae View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2016

  1. Merge pull request #3 from dotnet/master 

    FI from main
    @ljw1004
    ljw1004 authored Jun 17, 2016
    Configuration menu
    Copy the full SHA
    abc0efd View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2016

  1. Merge pull request #5 from dotnet/master 

    FI
    @ljw1004
    ljw1004 authored Jun 20, 2016
    Configuration menu
    Copy the full SHA
    6ecd515 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2016

  1. Merge pull request #6 from dotnet/master 

    FI
    @ljw1004
    ljw1004 authored Jul 1, 2016
    Configuration menu
    Copy the full SHA
    424da4a View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2016

  1. Merge pull request #9 from dotnet/master 

    FI from main
    @ljw1004
    ljw1004 authored Aug 25, 2016
    Configuration menu
    Copy the full SHA
    416cf98 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #10 from ljw1004/master 

    FI from main
    @ljw1004
    ljw1004 authored Aug 25, 2016
    Configuration menu
    Copy the full SHA
    1d6580a View commit details
    Browse the repository at this point in the history

  3. Altered the unit test source code to be based off [AsyncBuilder] attr… 

    …ibute, no longer off CreateAsyncMethodBuilder method.
    @ljw1004
    ljw1004 committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    3d82d1a View commit details
    Browse the repository at this point in the history

  4. First stab at making "async returns" be attribute-based

    @ljw1004
    ljw1004 committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    8b8d09d View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2016

  1. Fixed the unit-tests for AsyncBuilder attribute. They all now pass cl… 

    …eanly.
    @ljw1004
    ljw1004 committed Aug 26, 2016
    Configuration menu
    Copy the full SHA
    d7076e8 View commit details
    Browse the repository at this point in the history

  2. Updated the generic rules for [AsyncBuilder()] argument, and error-re… 

    …porting.
    @ljw1004
    ljw1004 committed Aug 26, 2016
    Configuration menu
    Copy the full SHA
    62a472f View commit details
    Browse the repository at this point in the history

  3. Added tests for the Create method

    @ljw1004
    ljw1004 committed Aug 26, 2016
    Configuration menu
    Copy the full SHA
    01eafc2 View commit details
    Browse the repository at this point in the history

  4. Change to enforce same accessibility between tasklike and builder

    @ljw1004
    ljw1004 committed Aug 26, 2016
    Configuration menu
    Copy the full SHA
    0ddec05 View commit details
    Browse the repository at this point in the history

  5. Update remaining tests for the new "accessibility of tasklike must ma… 

    …tch accessibility of builder" rule.
    @ljw1004
    ljw1004 committed Aug 26, 2016
    Configuration menu
    Copy the full SHA
    bcbd12f View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2016

  1. Added tests for AsyncBuilder attribute constructor with multiple para… 

    …meters, and for single parameter of wrong type
    @ljw1004
    ljw1004 committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    33e65fb View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2016

  1. [AsyncBuilder()] tests now mostly have a valid builder type, so as to… 

    … remove noise about "missing Create method" and "missing Task" method.
    @ljw1004
    ljw1004 committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    c9633b0 View commit details
    Browse the repository at this point in the history

  2. Factored out "ValidateAsyncBuilder" tests (that it's a type of correc… 

    …t arity/accessibility). Added an error report when builder can't be imported (and added a test for this).
    @ljw1004
    ljw1004 committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    eef0c70 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2016

  1. Followed convention of "(object)t != null" for types

    @ljw1004
    ljw1004 committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    0e30e90 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2016

  1. Minor tweaks. Made ValidateBuilderType method a bit simpler+cleaner. … 

    …Added more unit tests for bad builder, and for interface tasklike.
    @ljw1004
    ljw1004 committed Sep 1, 2016
    Configuration menu
    Copy the full SHA
    f2cdba8 View commit details
    Browse the repository at this point in the history