Type nested in generic type cannot be task-like #16528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
force-pushed
the
nested-tasklike
branch
from
0a5a843
to
f49c490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer scenario
The user makes a task-like type, but the async method builder has a
Taskproperty that returns a different type.Currently there is a generic error during emit (in retail mode) or an assertion (in debug mode). With this fix a proper error is reported.
Bugs this fixes:
Fixes #16493
Workarounds, if any
Avoid such bad code.
Risk
Performance impact
Low. Additional check on containing type in method that checks task-like types.
Is this a regression from a previous update?
No
Root cause analysis:
New feature.
How was the bug found?
Reported by customer.
@cston @dotnet/roslyn-compiler for review.