Fix NullReferenceException during debugging #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening a file during a debugging session, VS sets its buffer read-only when it is not editable. To do so, VS asks its document to the workspace but in some cases, the workspace returns nothing, causing NRE and VS Crash. Issue dotnet#1202 is tracking to fix this issue directly (by enforcing the workspace to load projects before EnC). In this PR, we defensively add a null check and log it to make a further investigation easier.
|
@tmat Can you have a look at this one? |
Add a TODO with an issue number dotnet#1204
|
Added TODO :) Thanks! |
wschae
added a commit
that referenced
this pull request
Apr 3, 2015
Fix NullReferenceException during debugging When opening a file during a debugging session, VS sets its buffer read-only when it is not editable. To do so, VS asks its document to the workspace but in some cases, the workspace returns nothing, causing NRE and VS Crash. In this PR, we defensively add a null check and log it to make a further investigation easier. Noth that Issue #1204 is tracking to fix this issue directly (by enforcing the workspace to load projects before EnC).
wschae
added a commit
that referenced
this pull request
Apr 4, 2015
Fix NullReferenceException during debugging It is a port of #1779 from main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a file during a debugging session, VS sets its buffer read-only when it is not editable. To do so, VS asks its document to the workspace but in some cases, the workspace returns nothing, causing NRE and VS Crash. In this PR, we defensively add a null check and log it to make a further investigation easier.
Noth that Issue #1204 is tracking to fix this issue directly (by enforcing the workspace to load projects before EnC).