Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove space from case. #17796

Merged
merged 1 commit into from
Mar 20, 2017
Merged

remove space from case. #17796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions src/EditorFeatures/CSharpTest/Diagnostics/NamingStyles/EditorConfigNamingStyleParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,5 +233,61 @@ public static void TestNoRulesAreReturned()
Assert.Empty(result.NamingStyles);
Assert.Empty(result.SymbolSpecifications);
}

[Fact]
public static void TestApplicableAccessibilitiesParse()
{
var charpRule = new Dictionary<string, object>()
{
["dotnet_naming_rule.accessibilities_parse.severity"] = "error",
["dotnet_naming_rule.accessibilities_parse.symbols"] = "accessibilities",
["dotnet_naming_rule.accessibilities_parse.style"] = "pascal_case",
["dotnet_naming_symbols.accessibilities.applicable_accessibilities"] = "internal,protected_internal",
["dotnet_naming_style.pascal_case.capitalization "] = "pascal_case",
};
var vbRule = new Dictionary<string, object>()
{
["dotnet_naming_rule.accessibilities_parse.severity"] = "error",
["dotnet_naming_rule.accessibilities_parse.symbols"] = "accessibilities",
["dotnet_naming_rule.accessibilities_parse.style"] = "pascal_case",
["dotnet_naming_symbols.accessibilities.applicable_accessibilities"] = "friend,protected_friend",
["dotnet_naming_style.pascal_case.capitalization "] = "pascal_case",
};

var csharpResult = ParseDictionary(charpRule);
var vbResult = ParseDictionary(vbRule);

Assert.Equal(csharpResult.SymbolSpecifications.SelectMany(x => x.ApplicableAccessibilityList),
vbResult.SymbolSpecifications.SelectMany(x => x.ApplicableAccessibilityList));
}

[Fact]
public static void TestRequiredModifiersParse()
{
var charpRule = new Dictionary<string, object>()
{
["dotnet_naming_rule.modifiers_parse.severity"] = "error",
["dotnet_naming_rule.modifiers_parse.symbols"] = "modifiers",
["dotnet_naming_rule.modifiers_parse.style"] = "pascal_case",
["dotnet_naming_symbols.modifiers.required_modifiers"] = "abstract,static",
["dotnet_naming_style.pascal_case.capitalization "] = "pascal_case",
};
var vbRule = new Dictionary<string, object>()
{
["dotnet_naming_rule.modifiers_parse.severity"] = "error",
["dotnet_naming_rule.modifiers_parse.symbols"] = "modifiers",
["dotnet_naming_rule.modifiers_parse.style"] = "pascal_case",
["dotnet_naming_symbols.modifiers.required_modifiers"] = "must_inherit,shared",
["dotnet_naming_style.pascal_case.capitalization "] = "pascal_case",
};

var csharpResult = ParseDictionary(charpRule);
var vbResult = ParseDictionary(vbRule);

Assert.Equal(csharpResult.SymbolSpecifications.SelectMany(x => x.RequiredModifierList.Select(y => y.Modifier)),
vbResult.SymbolSpecifications.SelectMany(x => x.RequiredModifierList.Select(y => y.Modifier)));
Assert.Equal(csharpResult.SymbolSpecifications.SelectMany(x => x.RequiredModifierList.Select(y => y.ModifierKindWrapper)),
vbResult.SymbolSpecifications.SelectMany(x => x.RequiredModifierList.Select(y => y.ModifierKindWrapper)));
}
}
}
2 changes: 1 addition & 1 deletion ...paces/Core/Portable/NamingStyles/EditorConfig/EditorConfigNamingStyleParser_SymbolSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ private static ImmutableArray<ModifierKind> ParseModifiers(string symbolSpecRequ
switch (symbolSpecRequiredModifier)
{
case "abstract":
case "must_inherit ":
case "must_inherit":
builder.Add(_abstractModifierKind);
break;
case "async":
Expand Down