Ivanbasov/integration tests #17885
Merged
Ivanbasov/integration tests #17885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @dotnet/roslyn-ide for more reviews. |
| namespace Roslyn.VisualStudio.IntegrationTests.CSharp | ||
| { | ||
| [Collection(nameof(SharedIntegrationHostFixture))] | ||
| public class CSharpInteractiveDemo : AbstractInteractiveWindowTest |
There was a problem hiding this comment.
This file was a duplicate of CSharpInteractive.cs
| public void CutDeletePasteSelectAll() | ||
| { | ||
| SendKeys("Text"); | ||
| ExecuteCommand("Edit.LineStart"); |
There was a problem hiding this comment.
nit: It would be nice if we had these commands centralized somewhere for general use.
There was a problem hiding this comment.
Thank you! Will update
| { | ||
| ClearReplText(); | ||
| InsertCode(" 2 + 4 "); | ||
| SendKeys(new KeyPress(VirtualKey.Z, ShiftState.Ctrl)); |
There was a problem hiding this comment.
nit: AbstractEditorTest provides a function for doing Ctrl(VirtualKey.Z): http://source.roslyn.io/#Roslyn.VisualStudio.IntegrationTests/AbstractEditorTest.cs,144, it would be nice if we could be consistent across the various tests.
There was a problem hiding this comment.
Thank you! Will update
tannergooding
approved these changes
Mar 16, 2017
jinujoseph
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First set of tests for #14369