Accessibility fixes for Naming Styles #17973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpoeschl
added
Area-IDE
Tenet-User Friendly
|
Tagging for review @dotnet/roslyn-ide |
| <value>Add a naming rule.</value> | ||
| </data> | ||
| <data name="Remove_naming_rule" xml:space="preserve"> | ||
| <value>Remove naming rule.</value> |
There was a problem hiding this comment.
are all the trailing periods intentional/desirable here?
There was a problem hiding this comment.
I completely don't care. It doesn't change how anything gets read.
| @@ -24,6 +24,11 @@ internal partial class NamingStyleOptionPageControl : AbstractOptionPageControl | |||
| public static string RequiredStyleHeader => ServicesVSResources.Required_Style; | |||
| public static string SeverityHeader => ServicesVSResources.Severity; | |||
| public static string ExplanatoryText => ServicesVSResources.For_a_given_symbol_only_the_topmost_rule_with_a_matching_Specification_will_be_applied_Violation_of_that_rules_Required_Style_will_be_reported_at_the_chosen_Severity_level; | |||
| public static string AddRuleAutomationText => ServicesVSResources.Add_a_naming_rule; | |||
| public static string RemoveAutomationText => ServicesVSResources.Remove_naming_rule; | |||
| public static string SymbolSpecification => ServicesVSResources.Symbol_Specification; | |||
There was a problem hiding this comment.
are the last tree also AutomationText?
There was a problem hiding this comment.
I'll fix up the naming
CyrusNajmabadi
approved these changes
Mar 19, 2017
dpoeschl
force-pushed
the
AccessibilityFixes2
branch
from
47d0704
to
0b0cea2
Compare
Pilchie
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems?_a=edit&id=391338&triage=true & https://devdiv.visualstudio.com/DevDiv/_workitems?_a=edit&id=391337&triage=true