Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use [NotNullWhenFalse] and [EnsuresNotNull] to drive nullability analysis #26656

Merged
merged 18 commits into from
May 15, 2018
Merged

Use [NotNullWhenFalse] and [EnsuresNotNull] to drive nullability analysis #26656

merged 18 commits into from
May 15, 2018

Commits on May 11, 2018

  1. Add well-known Debug.Assert method

    @jcouv
    jcouv committed May 11, 2018
    Configuration menu
    Copy the full SHA
    f35fded View commit details
    Browse the repository at this point in the history

  2. Make IsNullOrEmpty well-known

    @jcouv
    jcouv committed May 11, 2018
    Configuration menu
    Copy the full SHA
    e0ca0e3 View commit details
    Browse the repository at this point in the history

  3. Use attributes as annotation

    @jcouv
    jcouv committed May 11, 2018
    Configuration menu
    Copy the full SHA
    8160ab7 View commit details
    Browse the repository at this point in the history

  4. Fix test regressions

    @jcouv
    jcouv committed May 11, 2018
    Configuration menu
    Copy the full SHA
    9823b66 View commit details
    Browse the repository at this point in the history

  5. Implement NotNullWhenFalse and EnsuresNotNull

    @jcouv
    jcouv committed May 11, 2018
    Configuration menu
    Copy the full SHA
    967dafa View commit details
    Browse the repository at this point in the history

  6. Address PR feedback from Chuck

    @jcouv
    jcouv committed May 11, 2018
    Configuration menu
    Copy the full SHA
    2470a6f View commit details
    Browse the repository at this point in the history

  7. Add tests for metadata. Fix regression. Use regular, not early, attri… 

    …butes.
    @jcouv
    jcouv committed May 11, 2018
    Configuration menu
    Copy the full SHA
    5ae61fa View commit details
    Browse the repository at this point in the history

  8. Use enum. Annotations win

    @jcouv
    jcouv committed May 11, 2018
    Configuration menu
    Copy the full SHA
    78402d9 View commit details
    Browse the repository at this point in the history

  9. Diagnostics for invalid usage of attributes

    @jcouv
    jcouv committed May 11, 2018
    Configuration menu
    Copy the full SHA
    07a9ecd View commit details
    Browse the repository at this point in the history

  10. Address PR feedback from Chuck

    @jcouv
    jcouv committed May 11, 2018
    Configuration menu
    Copy the full SHA
    84ff12c View commit details
    Browse the repository at this point in the history

  11. Block params

    @jcouv
    jcouv committed May 11, 2018
    Configuration menu
    Copy the full SHA
    4e72481 View commit details
    Browse the repository at this point in the history

  12. Remove unused parameter

    @jcouv
    jcouv committed May 11, 2018
    Configuration menu
    Copy the full SHA
    b893f7b View commit details
    Browse the repository at this point in the history

  13. Fix merge conflict

    @jcouv
    jcouv committed May 11, 2018
    Configuration menu
    Copy the full SHA
    2188813 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2018

  1. WIP

    @jcouv
    jcouv committed May 14, 2018
    Configuration menu
    Copy the full SHA
    7c7573d View commit details
    Browse the repository at this point in the history

  2. Remove warning for misused attributes

    @jcouv
    jcouv committed May 14, 2018
    Configuration menu
    Copy the full SHA
    2036a25 View commit details
    Browse the repository at this point in the history

  3. Address PR feedback from Aleksey

    @jcouv
    jcouv committed May 14, 2018
    Configuration menu
    Copy the full SHA
    aea98d8 View commit details
    Browse the repository at this point in the history

  4. Missed change

    @jcouv
    jcouv committed May 14, 2018
    Configuration menu
    Copy the full SHA
    fa24db3 View commit details
    Browse the repository at this point in the history

  5. Fix comment and add test

    @jcouv
    jcouv committed May 14, 2018
    Configuration menu
    Copy the full SHA
    266b24c View commit details
    Browse the repository at this point in the history