Async completion bug fixes #28219
Closed
Async completion bug fixes #28219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// This method needs to support custom procesing of commit characters to be on par with the old completion implementation. | ||
| /// TODO we should consider removign this method and arrange better processing of commit characters. | ||
| /// </summary> | ||
| private bool IsCommitCharacter(char typeChar, ImmutableArray<CharacterSetModificationRule> rules) |
There was a problem hiding this comment.
two space between private and bool. #Resolved
| private bool IsCommitCharacter(char typeChar, ImmutableArray<CharacterSetModificationRule> rules) | ||
| { | ||
| // Tab, Enter and Null (call invoke commit) are always a commit character | ||
| if (typeChar == '\t' || typeChar == '\n' || typeChar == '\0') |
There was a problem hiding this comment.
it seriously worries me that:
- Enter is being sent through as typing '\n'.
- Commit is being sent through as typing \0
#Pending
There was a problem hiding this comment.
Thank you, Cyrus!
I just tried to be on par (comparing unit tests) with the old implementation. However, as I understand, previously we were able to handle e.g. Enter independently on all other key strokes. Now we have to make almost all decisions within the TryCommit method. So, we should process '\n' and '0' here. Do you have a suggestion?
In reply to: 200802172 [](ancestors = 200802172)
|
Merged into #29016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #27692, #27693