-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer completion for #nullable enable|disable
#31171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
added
Area-IDE
Area-Compilers
New Language Feature - Nullable Reference Types
Nullable Reference Types
labels
Nov 14, 2018
3 tasks
src/EditorFeatures/CSharpTest2/Recommendations/DisableKeywordRecommenderTests.cs
Show resolved
Hide resolved
src/Features/CSharp/Portable/Completion/KeywordRecommenders/NullableKeywordRecommender.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Nov 14, 2018
Thanks! |
sharwell
approved these changes
Nov 14, 2018
src/EditorFeatures/CSharpTest2/Recommendations/NullableKeywordRecommenderTests.cs
Show resolved
Hide resolved
src/EditorFeatures/CSharpTest2/Recommendations/EnableKeywordRecommenderTests.cs
Show resolved
Hide resolved
jcouv
force-pushed
the
nullable-completion
branch
from
November 15, 2018 00:22
52aed75
to
c20ff50
Compare
@jinujoseph for preview2 approval. Thanks |
AlekseyTs
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code under Compilers LGTM (iteration 5)
cston
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiler changes LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved to merge
Area-Compilers
Area-IDE
New Language Feature - Nullable Reference Types
Nullable Reference Types
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly an IDE fix, but also includes a minor fix to compiler APIs.
#nullable
#nullable enable|disable
Addresses part of #31130