add output paths as one of causes to reanalyze solution cralwer. #31181
Conversation
output paths are not specifically affecting semantics of code but some analyzer such as source based test discovery requires it to generate correct data. so they want to be re-analyzed when those are changed as well. since output path are rarely get changed. decide to add it as one of cause to reanalyze projects.
|
tagging @shyamnamboodiripad can you take a look? tagging @jinujoseph for preview 2 |
| !object.Equals(oldProject.DefaultNamespace, newProject.DefaultNamespace)) | ||
| !object.Equals(oldProject.DefaultNamespace, newProject.DefaultNamespace) || | ||
| !object.Equals(oldProject.OutputFilePath, newProject.OutputFilePath) || | ||
| !object.Equals(oldProject.OutputRefFilePath, newProject.OutputRefFilePath)) |
There was a problem hiding this comment.
We may need to change this again if it turns out that we need to change OutputFilePath back to the obj path and add an additional property for the 'bin' path... cc @jasonmalinowski
There was a problem hiding this comment.
Can we write this differently somehow so we don't have to keep updating this list? :-)
There was a problem hiding this comment.
Unrelated to this change, but it might be useful to have additional info on what have changed in project config, so individual analyzer can decide if it's OK to ignore the change. For example, source-based discovery won't be affected by changing analyzer options.
|
@dotnet/roslyn-infrastructure is this a known issue? ... AddResourceToModule Debug Work items Attachments History |
|
retest roslyn-CI please |
|
@heejaechang ADO rebuild works the way Jenkins was supposed to work, not using GitHub comments: 😄
|
output paths are not specifically affecting semantics of code but some analyzer such as source based test discovery requires it to generate correct data. so they want to be re-analyzed when those are changed as well.
since output path are rarely get changed. decide to add it as one of cause to reanalyze projects.