Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bail out on reporting unused parameter diagnostic for special paramet… #32883

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Bail out on reporting unused parameter diagnostic for special paramet… #32883

merged 1 commit into from
Jan 29, 2019

Commits on Jan 28, 2019

  1. Bail out on reporting unused parameter diagnostic for special paramet… 

    …er names

We ignore parameter names that start with an underscore and are optionally followed by an integer, such as '_', '_1', '_2', etc.
This allows bailing out on unused parameters for methods that need a specific signature and are forced to have these parameters. This also serves as a convenient way to suppress instances of unused parameter diagnostic without disabling the diagnostic completely.

Fixes dotnet#32851
Fixes dotnet#32228
    @mavasani
    mavasani committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    fde89f3 View commit details
    Browse the repository at this point in the history