Filter optprof to specific tests #35700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chsienki
force-pushed
the
streamline_optprof
branch
from
e2470ce to
1bf8ec6
Compare
- Check opt prof file is valid via build boss - Update OptProf.json with errors found
chsienki
force-pushed
the
streamline_optprof
branch
from
1d84e8c to
d44241e
Compare
jaredpar
reviewed
May 28, 2019
|
|
||
| // validate that each vsix listed in it is valid | ||
| bool allGood = true; | ||
| foreach (var product in optProfFile["products"]) |
There was a problem hiding this comment.
Consider an error if this collection is empty
jaredpar
reviewed
May 28, 2019
| foreach (var filteredTest in filteredTests) | ||
| { | ||
| var filename = filteredTest["filename"].ToString(); | ||
| if (!manifestFileNames.Contains(filename)) |
There was a problem hiding this comment.
Note: this means the file name comparison is ordinal. Is that intentional? Seems okay.
chsienki
force-pushed
the
streamline_optprof
branch
from
e32bdfc to
d31ae09
Compare
chsienki
force-pushed
the
streamline_optprof
branch
from
d31ae09 to
e32bdfc
Compare
jaredpar
approved these changes
Nov 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.