Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine diagnostic for switch expression that is not exhaustive #38714

Merged
merged 2 commits into from
Sep 20, 2019
Merged

Refine diagnostic for switch expression that is not exhaustive #38714

merged 2 commits into from
Sep 20, 2019

Conversation

gafter
Copy link
Member

@gafter gafter commented Sep 16, 2019

Fixes #38571

@gafter gafter added this to the 16.4 milestone Sep 16, 2019
@gafter gafter requested a review from a team as a code owner September 16, 2019 22:39
@gafter gafter self-assigned this Sep 16, 2019
@333fred
Copy link
Member

333fred commented Sep 18, 2019

Missing XLF files though.

jcouv
jcouv approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1) modulo missing XLF files

@jcouv jcouv self-assigned this Sep 19, 2019
@gafter gafter merged commit 35cc9bb into dotnet:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@gafter gafter

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
16.4
Development

Successfully merging this pull request may close these issues.

CS8509 The switch expression does not handle all possible inputs when it does
3 participants
@gafter @333fred @jcouv