Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse test analyzer data using InvariantCulture #39254

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Parse test analyzer data using InvariantCulture #39254

merged 1 commit into from
Oct 14, 2019

Conversation

castholm
Copy link
Contributor

Fixes #39248.

I quickly went over all other references to EnsureEnglishUICulture.PreferredOrNull and to my knowledge this is the only place where it is used to parse numeric data, so I don't believe its behavior needs to be changed.

@castholm castholm requested a review from a team as a code owner October 12, 2019 18:45
@sharwell sharwell added Area-Infrastructure Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Oct 12, 2019
@jinujoseph jinujoseph added this to the 16.4.P3 milestone Oct 14, 2019
@jinujoseph jinujoseph merged commit f6b62a3 into dotnet:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
3 participants