Re-add ServiceFeatureOnOffOptions.ClosedFileDiagnostic to fix the bre… #39955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ak for TS and F# Recent PR dotnet#39699 introduced a breaking API and functionality change for TypeScript and F# as they are using our internal option ClosedFileDiagnostics for controlling their full solution analysis experience. This PR restores the ClosedFileDiagnostics option and functionality for non C#/VB languages. Additionally, the newly added option SolutionCrawlerOptions.BackgroundAnalysisScope has been made a per-language option so that all languages can have different UI/setting for this option.
jasonmalinowski
approved these changes
Nov 22, 2019
src/Workspaces/Core/Portable/SolutionCrawler/ServiceFeatureOnOffOptions.cs
Outdated
Show resolved
Hide resolved
| { | ||
| case LanguageNames.CSharp: | ||
| case LanguageNames.VisualBasic: | ||
| return options.GetOption(BackgroundAnalysisScopeOption, language); |
There was a problem hiding this comment.
So are we ignoring previous settings of the open/closed diagnostics setting for C# and VB? We don't want to read those if the new one hasn't been set?
There was a problem hiding this comment.
There is no UI to set the older option for C# and VB though. Also, I am not sure how would we hook up option page setting based on 2 options. Current BindToOption approach simply connects the UI radio button to the new option. Having said that, we can potentially set this up somehow, but I am not sure if the effort is worth it.
|
Merging this to unblock insertion. I will address any additional feedback with a follow-up PR. |
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Nov 22, 2019
dotnet#39955 re-added the option back to Workspaces instead of Features, its original location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ak for TS and F#
Recent PR #39699 introduced a breaking API and functionality change for TypeScript and F# as they are using our internal option
ClosedFileDiagnosticfor controlling their full solution analysis experience. This PR restores this option and functionality for non-C#/VB languages. Additionally, the newly added optionSolutionCrawlerOptions.BackgroundAnalysisScopehas been made a per-language option so that all languages can have different UI/setting for this option.