Update code style layer to Microsoft.CodeAnalysis 3.3.1 #41096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
force-pushed
the
coding-conventions
branch
from
a8c8857 to
35a3a00
Compare
sharwell
force-pushed
the
coding-conventions
branch
from
35a3a00 to
22b2526
Compare
sharwell
changed the base branch from
master
to
AddLangServiceSatelliteAssemblies-180725
sharwell
changed the base branch from
AddLangServiceSatelliteAssemblies-180725
to
master
mavasani
reviewed
Jan 21, 2020
mavasani
approved these changes
Jan 21, 2020
sharwell
force-pushed
the
coding-conventions
branch
from
a34c071 to
00df672
Compare
sharwell
added
PR For Personal Review Only
mavasani
reviewed
Jan 24, 2020
|
|
||
| namespace Microsoft.CodeAnalysis | ||
| { | ||
| internal abstract class OptionSet | ||
| internal sealed class CompilerAnalyzerConfigOptions : AnalyzerConfigOptions |
There was a problem hiding this comment.
Is this type being used anywhere now? Seems weird as its TryGetValue always returns false.
mavasani
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to load Microsoft.VisualStudio.CodingConventions via the diagnostic analyzer service causes conflicts with Visual Studio extensions that depend on the same assembly. See pharring/EditorGuidelines#21 for example. This change updates the code style layer to use the new .editorconfig support from the compiler exclusively, and removes the dependency on Microsoft.VisualStudio.CodingConventions.
Following this change, the NuGet-installed FormattingAnalyzer requires Roslyn 16.3 or newer.