Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codegen for module initializers feature #43281

Merged
merged 24 commits into from
Apr 28, 2020
Merged

Codegen for module initializers feature #43281

merged 24 commits into from
Apr 28, 2020

Commits on Apr 11, 2020

  1. Decode ModuleInitializerAttribute to SourceMethodSymbolWithAttributes… 

    ….IsModuleInitializer
    @jnm2
    jnm2 committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    8c28e24 View commit details
    Browse the repository at this point in the history

  2. Check feature availability

    @jnm2
    jnm2 committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    223ef89 View commit details
    Browse the repository at this point in the history

  3. Test for simple success case

    @jnm2
    jnm2 committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    a51bac2 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2020

  1. Method is not specific to PrivateImplementationDetails

    @jnm2
    jnm2 committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    44d207d View commit details
    Browse the repository at this point in the history

  2. Simplify RootModuleType.cs

    @jnm2
    jnm2 committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    ee873ab View commit details
    Browse the repository at this point in the history

  3. Compile synthesized methods that the root module type may have

    @jnm2
    jnm2 committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    f5fe948 View commit details
    Browse the repository at this point in the history

  4. Emit root module type constructor calling the module initializer methods

    @jnm2
    jnm2 committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    4e4889a View commit details
    Browse the repository at this point in the history

  5. Fix the <Module> method full names in the CompilationTestData that th… 

    …e compiler produces
    @jnm2
    jnm2 committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    46e61ef View commit details
    Browse the repository at this point in the history

  6. Freeze the root module type since it is processed when emitting metad… 

    …ata only
    @jnm2
    jnm2 committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    e509e89 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. Apply suggestions from code review 

    Review suggestions using PROTOTYPE in comments

Co-Authored-By: Rikki Gibson <rikkigibson@gmail.com>
    @jnm2 @RikkiGibson
    jnm2 and RikkiGibson authored Apr 13, 2020
    Configuration menu
    Copy the full SHA
    b4d607b View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. Inline now and extract as private method later

    @jnm2
    jnm2 committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    7308772 View commit details
    Browse the repository at this point in the history

  2. Add suggested comment where features are mapped to versions

    @jnm2
    jnm2 committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    f50aa4c View commit details
    Browse the repository at this point in the history

  3. Revert in preparation for taking an approach that is not based on syn… 

    …thesized symbols
    @jnm2
    jnm2 committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    5908d80 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2020

  1. Store decoded ModuleInitializerAttribute state directly on the compil… 

    …ation
    @jnm2
    jnm2 committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    0290b4c View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2020

  1. Emit without synthesizing symbols

    @jnm2
    jnm2 committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    a64bb21 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. Assert that SetStaticConstructorBody is not called after GetMethods

    @jnm2
    jnm2 committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    f144ce2 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary GetModuleInitializerMethods method

    @jnm2
    jnm2 committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    11c64a8 View commit details
    Browse the repository at this point in the history

  3. fixup! Emit without synthesizing symbols

    @jnm2
    jnm2 committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    2960b8b View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary dependency on SourceMethodSymbolWithAttributes.Syn… 

    …taxNode
    @jnm2
    jnm2 committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    0d0936d View commit details
    Browse the repository at this point in the history

  5. Use ConcurrentSet to prevent duplicates

    @jnm2
    jnm2 committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    a83e6df View commit details
    Browse the repository at this point in the history

  6. Allow any MethodSymbol to be added as a module initializer for the co… 

    …mpilation
    @jnm2
    jnm2 committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    8fb31ed View commit details
    Browse the repository at this point in the history

  7. Assert expected metadata flags

    @jnm2
    jnm2 committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    34dd24a View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2020

  1. Add specific test that C# 9 is the first version supporting module in… 

    …itializers
    @jnm2
    jnm2 committed Apr 25, 2020
    Configuration menu
    Copy the full SHA
    771e905 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Merge branch 'features/module-initializers' of github.com:dotnet/rosl… 

    …yn into module_initializers/success_case
    @RikkiGibson
    RikkiGibson committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    1f34d13 View commit details
    Browse the repository at this point in the history