Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostics for module initializers feature #43301

Merged
merged 37 commits into from
May 12, 2020
Merged

Diagnostics for module initializers feature #43301

merged 37 commits into from
May 12, 2020

Commits on Apr 29, 2020

  1. Planned diagnostics

    @jnm2
    jnm2 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    6ebb7b0 View commit details
    Browse the repository at this point in the history

  2. Accessibility diagnostics

    @jnm2
    jnm2 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    ad85620 View commit details
    Browse the repository at this point in the history

  3. Signature diagnostics

    @jnm2
    jnm2 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    37bcdea View commit details
    Browse the repository at this point in the history

  4. Improve readability

    @jnm2
    jnm2 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    f6ee321 View commit details
    Browse the repository at this point in the history

  5. Generics diagnostics

    @jnm2
    jnm2 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    f1f5a38 View commit details
    Browse the repository at this point in the history

  6. Usages ignored without diagnostics

    @jnm2
    jnm2 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    618d89a View commit details
    Browse the repository at this point in the history

  7. Multiple application is ignored

    @jnm2
    jnm2 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    0ae310f View commit details
    Browse the repository at this point in the history

  8. Couple more valid cases

    @jnm2
    jnm2 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    fb425a8 View commit details
    Browse the repository at this point in the history

  9. Diagnostic to cover the gap left by AttributeTargets.Method

    @jnm2
    jnm2 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    3153060 View commit details
    Browse the repository at this point in the history

  10. Cover the gap left by AttributeTargets.Method

    @jnm2
    jnm2 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    3255afa View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. 'Visibility' → 'Accessibility'

    @jnm2
    jnm2 committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    724d23d View commit details
    Browse the repository at this point in the history

  2. Group tests that vary only by keywords into theories

    @jnm2
    jnm2 committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    32d8526 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2020

  1. Reserve the term 'ignored on' to indicate relying on AttributeUsage

    @jnm2
    jnm2 committed May 1, 2020
    Configuration menu
    Copy the full SHA
    c525661 View commit details
    Browse the repository at this point in the history

  2. Named arguments are not relevant

    @jnm2
    jnm2 committed May 1, 2020
    Configuration menu
    Copy the full SHA
    dc2ad6b View commit details
    Browse the repository at this point in the history

  3. <Module> type is no longer available to VerifyIL and VerifyMemberInIL

    @jnm2
    jnm2 committed May 1, 2020
    Configuration menu
    Copy the full SHA
    bdfce43 View commit details
    Browse the repository at this point in the history

  4. Fix placeholder name

    @jnm2
    jnm2 committed May 1, 2020
    Configuration menu
    Copy the full SHA
    03b0c49 View commit details
    Browse the repository at this point in the history

  5. Emit diagnostics should be verified

    @jnm2
    jnm2 committed May 1, 2020
    Configuration menu
    Copy the full SHA
    3f31030 View commit details
    Browse the repository at this point in the history

  6. Success cases should be executed

    @jnm2
    jnm2 committed May 1, 2020
    Configuration menu
    Copy the full SHA
    22af1ab View commit details
    Browse the repository at this point in the history

  7. Invalid methods should not be added as module initializers

    @jnm2
    jnm2 committed May 1, 2020
    Configuration menu
    Copy the full SHA
    b140ab9 View commit details
    Browse the repository at this point in the history

  8. Use existing helper to check accessibility

    @jnm2
    jnm2 committed May 1, 2020
    Configuration menu
    Copy the full SHA
    3328ade View commit details
    Browse the repository at this point in the history

Commits on May 2, 2020

  1. Draw the line between ignored and error placements as defined by the … 

    …SourceMethod boundary rather than AttributeTargets.Method
    @jnm2
    jnm2 committed May 2, 2020
    Configuration menu
    Copy the full SHA
    fc412ac View commit details
    Browse the repository at this point in the history

  2. Mirror tests requested for mismatching AttributeTargets

    @jnm2
    jnm2 committed May 2, 2020
    Configuration menu
    Copy the full SHA
    8f576b5 View commit details
    Browse the repository at this point in the history

  3. Report additional diagnostics from accessibility check as requested

    @jnm2
    jnm2 committed May 2, 2020
    Configuration menu
    Copy the full SHA
    6663f90 View commit details
    Browse the repository at this point in the history

  4. Unify error messages as suggested in review, referencing WRN_MainCant… 

    …BeGeneric and MissingDeconstruct and quoting 'void' as inline syntax rather than as language terminology
    @jnm2
    jnm2 committed May 2, 2020
    Configuration menu
    Copy the full SHA
    fb488e0 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Update code comments to be consistent with .resx change

    @jnm2
    jnm2 committed May 6, 2020
    Configuration menu
    Copy the full SHA
    c36b167 View commit details
    Browse the repository at this point in the history

  2. Clearer message for inaccessible module initializer methods

    @jnm2
    jnm2 committed May 6, 2020
    Configuration menu
    Copy the full SHA
    cb70fe4 View commit details
    Browse the repository at this point in the history

  3. Prevent false negatives when expecting a missing module initializer

    @jnm2
    jnm2 committed May 6, 2020
    Configuration menu
    Copy the full SHA
    8212adc View commit details
    Browse the repository at this point in the history

  4. Make ignored constructor attribute tests more interesting

    @jnm2
    jnm2 committed May 6, 2020
    Configuration menu
    Copy the full SHA
    81b4d33 View commit details
    Browse the repository at this point in the history

  5. Fix merge conflicts

    @jnm2
    jnm2 committed May 6, 2020
    Configuration menu
    Copy the full SHA
    0aba90d View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. Not accessibility tests

    @jnm2
    jnm2 committed May 8, 2020
    Configuration menu
    Copy the full SHA
    dc03fbe View commit details
    Browse the repository at this point in the history

  2. Fix merge conflicts

    @jnm2
    jnm2 committed May 8, 2020
    Configuration menu
    Copy the full SHA
    a689bf4 View commit details
    Browse the repository at this point in the history

  3. Write the correct member name

    @jnm2
    jnm2 committed May 8, 2020
    Configuration menu
    Copy the full SHA
    f3adf4e View commit details
    Browse the repository at this point in the history

  4. Add tests of conditional method and attribute

    @jnm2
    jnm2 committed May 8, 2020
    Configuration menu
    Copy the full SHA
    afcb701 View commit details
    Browse the repository at this point in the history

  5. Do not emit call to method that is conditionally excluded

    @jnm2
    jnm2 committed May 8, 2020
    Configuration menu
    Copy the full SHA
    5d9c8d8 View commit details
    Browse the repository at this point in the history

  6. Verify that a module initializer is emitted for an extern method

    @jnm2
    jnm2 committed May 8, 2020
    Configuration menu
    Copy the full SHA
    64269a9 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2020

  1. Use subfolder instead of partial classes

    @jnm2
    jnm2 committed May 9, 2020
    Configuration menu
    Copy the full SHA
    e11ff63 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Test both orders of ModuleInitializerAttribute and ConditionalAttribute

    @jnm2
    jnm2 committed May 12, 2020
    Configuration menu
    Copy the full SHA
    23e81d7 View commit details
    Browse the repository at this point in the history